You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/02/07 20:40:42 UTC

Review Request 56402: Ambari scripts have 777 permission which is a major security concern (change came from 2.4.x)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56402/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19902
    https://issues.apache.org/jira/browse/AMBARI-19902


Repository: ambari


Description
-------

If we look at the below output these files have 777 perms : 
{code}
[root@h1 ~]# ll /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
-rwxrwxrwx. 1 root root 22471 Nov 23 07:40 /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 

[root@h1 ~]# ll /var/lib/ambari-server/resources/scripts/configs.sh 
-rwxrwxrwx. 1 root root 9801 Nov 23 07:27 /var/lib/ambari-server/resources/scripts/configs.sh 
{code}


Diffs
-----

  ambari-agent/pom.xml 79fa32c 
  ambari-server/src/main/assemblies/server.xml d65232c 

Diff: https://reviews.apache.org/r/56402/diff/


Testing
-------


Thanks,

Vitalyi Brodetskyi


Re: Review Request 56402: Ambari scripts have 777 permission which is a major security concern (change came from 2.4.x)

Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56402/#review164744
-----------------------------------------------------------


Ship it!




Ship It!

- Swapan Shridhar


On Feb. 7, 2017, 8:40 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56402/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19902
>     https://issues.apache.org/jira/browse/AMBARI-19902
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If we look at the below output these files have 777 perms : 
> {code}
> [root@h1 ~]# ll /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> -rwxrwxrwx. 1 root root 22471 Nov 23 07:40 /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> 
> [root@h1 ~]# ll /var/lib/ambari-server/resources/scripts/configs.sh 
> -rwxrwxrwx. 1 root root 9801 Nov 23 07:27 /var/lib/ambari-server/resources/scripts/configs.sh 
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml 79fa32c 
>   ambari-server/src/main/assemblies/server.xml d65232c 
> 
> Diff: https://reviews.apache.org/r/56402/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 56402: Ambari scripts have 777 permission which is a major security concern (change came from 2.4.x)

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56402/#review164647
-----------------------------------------------------------


Ship it!




Ship It!

- Dmytro Sen


On \u0424\u0435\u0432. 7, 2017, 8:40 \u043f.\u043f., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56402/
> -----------------------------------------------------------
> 
> (Updated \u0424\u0435\u0432. 7, 2017, 8:40 \u043f.\u043f.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19902
>     https://issues.apache.org/jira/browse/AMBARI-19902
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If we look at the below output these files have 777 perms : 
> {code}
> [root@h1 ~]# ll /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> -rwxrwxrwx. 1 root root 22471 Nov 23 07:40 /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> 
> [root@h1 ~]# ll /var/lib/ambari-server/resources/scripts/configs.sh 
> -rwxrwxrwx. 1 root root 9801 Nov 23 07:27 /var/lib/ambari-server/resources/scripts/configs.sh 
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml 79fa32c 
>   ambari-server/src/main/assemblies/server.xml d65232c 
> 
> Diff: https://reviews.apache.org/r/56402/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 56402: Ambari scripts have 777 permission which is a major security concern (change came from 2.4.x)

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56402/#review164747
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 7, 2017, 8:40 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56402/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19902
>     https://issues.apache.org/jira/browse/AMBARI-19902
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If we look at the below output these files have 777 perms : 
> {code}
> [root@h1 ~]# ll /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> -rwxrwxrwx. 1 root root 22471 Nov 23 07:40 /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> 
> [root@h1 ~]# ll /var/lib/ambari-server/resources/scripts/configs.sh 
> -rwxrwxrwx. 1 root root 9801 Nov 23 07:27 /var/lib/ambari-server/resources/scripts/configs.sh 
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml 79fa32c 
>   ambari-server/src/main/assemblies/server.xml d65232c 
> 
> Diff: https://reviews.apache.org/r/56402/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 56402: Ambari scripts have 777 permission which is a major security concern (change came from 2.4.x)

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56402/#review164685
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Onischuk


On Feb. 7, 2017, 8:40 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56402/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19902
>     https://issues.apache.org/jira/browse/AMBARI-19902
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If we look at the below output these files have 777 perms : 
> {code}
> [root@h1 ~]# ll /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> -rwxrwxrwx. 1 root root 22471 Nov 23 07:40 /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> 
> [root@h1 ~]# ll /var/lib/ambari-server/resources/scripts/configs.sh 
> -rwxrwxrwx. 1 root root 9801 Nov 23 07:27 /var/lib/ambari-server/resources/scripts/configs.sh 
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml 79fa32c 
>   ambari-server/src/main/assemblies/server.xml d65232c 
> 
> Diff: https://reviews.apache.org/r/56402/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>