You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Cheolsoo Park (JIRA)" <ji...@apache.org> on 2012/06/27 09:37:46 UTC
[jira] [Comment Edited] (SQOOP-494) Create client infrastructure to
allow interactive selection of options of a command.
[ https://issues.apache.org/jira/browse/SQOOP-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402026#comment-13402026 ]
Cheolsoo Park edited comment on SQOOP-494 at 6/27/12 7:36 AM:
--------------------------------------------------------------
I incorporated Vasanth's comments.
Beside the changes, I also added two junit tests for "show server" and "set server". I used expectj to simulate interactive session, and you can run these tests with maven.
I didn't add tests for other commands such as "show version" and "show connector" because they require the server as well as the client. As of now, my junit tests only start the client shell via expectj.
In the long term, I'd like to use expectj in the front-end for all end-to-end tests. I am going to do that work as part of SQOOP-506.
For now, I see two more minor things that I'd like to improve if time permits:
1) The order of choices in a m/c question is not sorted. This is because OptionGroup stores options in an unsorted hashmap.
2) The quit choice 'q' in a m/c question does not stand out. The user might be confused what 'q' is for.
Please let me know what you think.
Thanks!
was (Author: cheolsoo):
I incorporated Vasanth's comments.
Beside the changes, I also added two junit tests for "show server" and "set server". I used expectj to simulate interactive session, and you can run these tests with maven.
I didn't add tests for other commands such as "show version" and "show connector" because they require the server as well as the client. As of now, my junit tests only start the client shell via expectj.
In the long term, I'd like to use expectj in the front-end for all end-to-end tests. I am going to do that work as part of SQOOP-506.
For now, I see two more minor things that I'd like to improve if time permits:
1) The order of choices in a m/c question is not sorted. This is because OptionGroup stores options in an unsorted hashmap.
2) The quit choice 'q' in a m/c question does not stand out. The user might be confused what
'q' is for.
Please let me know what you think.
Thanks!
> Create client infrastructure to allow interactive selection of options of a command.
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-494
> URL: https://issues.apache.org/jira/browse/SQOOP-494
> Project: Sqoop
> Issue Type: Task
> Reporter: Arvind Prabhakar
> Assignee: Cheolsoo Park
> Fix For: 2.0.0
>
> Attachments: SQOOP-494.patch, SQOOP-494.patch, SQOOP-494.patch, SQOOP-494.patch
>
>
> For example, if a command does not have full options specified, instead of displaying full help, the shell could get into an interactive session to gather the options one by one from the user.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira