You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Syed Albiz <s....@gmail.com> on 2011/06/12 06:30:57 UTC
Review Request: HIVE-2100: virtual column references inside subqueries cause
execution exceptions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/886/
-----------------------------------------------------------
Review request for hive, John Sichi and Yongqiang He.
Summary
-------
Instead of excluding the operator from the opCtxMap entirely, I added an additional check to the operator initialization to make sure that at least one file path for the operator was valid before initialization.
This addresses bug HIVE-2100.
https://issues.apache.org/jira/browse/HIVE-2100
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 96a1631
Diff: https://reviews.apache.org/r/886/diff
Testing
-------
Passes authorization_part.q and nestedvirtual.q. Running test suite now to check for any other regressions.
Thanks,
Syed
Re: Review Request: HIVE-2100: virtual column references inside subqueries
cause execution exceptions
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/886/
-----------------------------------------------------------
(Updated 2011-06-28 23:26:58.331721)
Review request for hive, John Sichi and Yongqiang He.
Changes
-------
since database.q failed in the testcase suite, I can't see any reason not to just call setInspectorInput() on every input that gets added to the OpCtxMap which solves both this and the original problem.
Summary
-------
Instead of excluding the operator from the opCtxMap entirely, I added an additional check to the operator initialization to make sure that at least one file path for the operator was valid before initialization.
This addresses bug HIVE-2100.
https://issues.apache.org/jira/browse/HIVE-2100
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 96a1631
ql/src/test/queries/clientpositive/nestedvirtual.q PRE-CREATION
ql/src/test/results/clientpositive/nestedvirtual.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/886/diff
Testing
-------
Passes authorization_part.q and nestedvirtual.q. Running test suite now to check for any other regressions.
Thanks,
Syed
Re: Review Request: HIVE-2100: virtual column references inside subqueries
cause execution exceptions
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/886/
-----------------------------------------------------------
(Updated 2011-06-12 04:35:06.377639)
Review request for hive, John Sichi and Yongqiang He.
Changes
-------
forgot to include new unit tests, included in this patch
Summary
-------
Instead of excluding the operator from the opCtxMap entirely, I added an additional check to the operator initialization to make sure that at least one file path for the operator was valid before initialization.
This addresses bug HIVE-2100.
https://issues.apache.org/jira/browse/HIVE-2100
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 96a1631
ql/src/test/queries/clientpositive/nestedvirtual.q PRE-CREATION
ql/src/test/results/clientpositive/nestedvirtual.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/886/diff
Testing
-------
Passes authorization_part.q and nestedvirtual.q. Running test suite now to check for any other regressions.
Thanks,
Syed