[jira] Reopened: (THRIFT-646) Erlang library is missing install target

["Anthony Molinaro (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anthony Molinaro reopened THRIFT-646:
-------------------------------------

      Assignee: David Reiss  (was: Anthony Molinaro)

Actually, I just noticed in trying out the 0.4.0 tar which supposedly fixes this that your update to my patch installs the library in the wrong place.  Instead of getting the install directory by asking erl where it is in the Makefile.am like

ERL_LIB_ROOT_DIR=$(shell erl -eval 'io:format("~s~n", [code:lib_dir()])' -s init stop -noshell)

you call a macro called AC_ERLANG_SUBST_INSTALL_LIB_DIR which for some reason is based on libdir?  There seems to be a macro called AC_ERLANG_SUBST_LIB_DIR which is equivalent to the line above in that it calls code:lib_dir() and uses that
as a substitution value.   So maybe change to AC_ERLANG_SUBST_LIB_DIR in configure.ac, and use $(ERLANG_LIB_DIR)/$(AC_PACKAGE_NAME)-$(AC_PACKAGE_VERSION) in place of $(ERLANG_INSTALL_LIB_DIR_thrift) in the lib/erl/Makefile.am?

> Erlang library is missing install target
> ----------------------------------------
>
>                 Key: THRIFT-646
>                 URL: https://issues.apache.org/jira/browse/THRIFT-646
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.2
>            Reporter: Anthony Molinaro
>            Assignee: David Reiss
>             Fix For: 0.4
>
>         Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
>     echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang.  This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.