You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Chris Lampley (JIRA)" <ji...@apache.org> on 2010/12/29 16:33:45 UTC

[jira] Created: (WICKET-3292) CreditCardValidator will erroneously mark some exotic card types as invalid

CreditCardValidator will erroneously mark some exotic card types as invalid
---------------------------------------------------------------------------

                 Key: WICKET-3292
                 URL: https://issues.apache.org/jira/browse/WICKET-3292
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.5-M3, 1.4.15
            Reporter: Chris Lampley
            Priority: Minor


CreditCardValidator will mark valid card numbers invalid if it does not recognize the card type based on prefix and will also pass some card numbers based on prefix alone without performing a Luhn check.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (WICKET-3292) CreditCardValidator will erroneously mark some exotic card types as invalid

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag reassigned WICKET-3292:
------------------------------------------

    Assignee: Juergen Donnerstag

> CreditCardValidator will erroneously mark some exotic card types as invalid
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-3292
>                 URL: https://issues.apache.org/jira/browse/WICKET-3292
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.15, 1.5-M3
>            Reporter: Chris Lampley
>            Assignee: Juergen Donnerstag
>            Priority: Minor
>         Attachments: CreditCardValidator.patch
>
>
> CreditCardValidator will mark valid card numbers invalid if it does not recognize the card type based on prefix and will also pass some card numbers based on prefix alone without performing a Luhn check.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-3292) CreditCardValidator will erroneously mark some exotic card types as invalid

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-3292.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M4

> CreditCardValidator will erroneously mark some exotic card types as invalid
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-3292
>                 URL: https://issues.apache.org/jira/browse/WICKET-3292
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.15, 1.5-M3
>            Reporter: Chris Lampley
>            Assignee: Juergen Donnerstag
>            Priority: Minor
>             Fix For: 1.5-M4
>
>         Attachments: CreditCardValidator.patch
>
>
> CreditCardValidator will mark valid card numbers invalid if it does not recognize the card type based on prefix and will also pass some card numbers based on prefix alone without performing a Luhn check.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-3292) CreditCardValidator will erroneously mark some exotic card types as invalid

Posted by "Chris Lampley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Lampley updated WICKET-3292:
----------------------------------

    Attachment: CreditCardValidator.patch

Adding a patch to fix this issue also with a couple improvements. This change makes the validator no longer attempt to find the card type on the card number. It simply performs a Luhn check and will allow the card number if the check passes. Also, the card type detection code has completely been removed as all methods were simply marked as private, forcing the validator to do unnecessary work since it never provided the type to the outside world anyway.



> CreditCardValidator will erroneously mark some exotic card types as invalid
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-3292
>                 URL: https://issues.apache.org/jira/browse/WICKET-3292
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.15, 1.5-M3
>            Reporter: Chris Lampley
>            Priority: Minor
>         Attachments: CreditCardValidator.patch
>
>
> CreditCardValidator will mark valid card numbers invalid if it does not recognize the card type based on prefix and will also pass some card numbers based on prefix alone without performing a Luhn check.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.