You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/08 22:04:08 UTC

[GitHub] [nifi] mattyb149 commented on a diff in pull request #6635: NIFI-10781 Made the MongoDB controller service implement VerifiableCo…

mattyb149 commented on code in PR #6635:
URL: https://github.com/apache/nifi/pull/6635#discussion_r1017158003


##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-client-service-api/src/main/java/org/apache/nifi/mongodb/MongoDBClientService.java:
##########
@@ -40,33 +41,33 @@ public interface MongoDBClientService extends ControllerService {
      String WRITE_CONCERN_W2 = "W2";
      String WRITE_CONCERN_W3 = "W3";
 
-     static final AllowableValue WRITE_CONCERN_ACKNOWLEDGED_VALUE = new AllowableValue(

Review Comment:
   Is there a reason that these shouldn't be `static final`? Otherwise this LGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org