[GitHub] [geode] kirklund commented on a change in pull request #6659: GEODE-9404: Do not log error message if sender is not configured.

[GitBox <gi...@apache.org>]

kirklund commented on a change in pull request #6659:
URL: https://github.com/apache/geode/pull/6659#discussion_r665558895



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java
##########
@@ -253,7 +253,8 @@ public void firePendingCallbacks() {
     }
 
     for (EntryEventImpl ee : getPendingCallbacks()) {
-      boolean isLastTransactionEvent = isConfigError || ee.equals(lastTransactionEvent);
+      boolean isLastTransactionEvent =
+          isConfigError || lastTransactionEvent == null || ee.equals(lastTransactionEvent);

Review comment:
       This is the 2nd instance of this same code which was is in TXCommitMessage.java. You might want to create a static utils method and have both of these call that method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org