You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/23 02:16:55 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #2667: [IOTDB-1152] optimize regular data size in traversing

HTHou commented on a change in pull request #2667:
URL: https://github.com/apache/iotdb/pull/2667#discussion_r580726201



##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/RegularDataEncoder.java
##########
@@ -220,7 +223,7 @@ private void data2Diff(int[] missingPointData) {
       bitmap = new BitSet(newBlockSize);
       bitmap.flip(0, newBlockSize);
       int offset = 0;
-      for (int i = 1; i < missingPointData.length; i++) {
+      for (int i = 1; i < dataTotal; i++) {

Review comment:
       Just a small suggestion, would you like adding some the comments here? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org