You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sdf-jkl (via GitHub)" <gi...@apache.org> on 2026/10/06 21:18:35 UTC

[PR] Add Variant integer-to-decimal and float-to-decimal benchmarks [arrow-rs]

sdf-jkl opened a new pull request, #11416:
URL: https://github.com/apache/arrow-rs/pull/11416

   # Which issue does this PR close?
   
   - Relates to #10795 and #11309.
   - Adds Variant benchmark coverage for #11302 and the integer conversion fix tracked in #11309.
   
   # Rationale for this change
   
   The existing `variant_get` benchmarks do not cover integer or floating-point conversion to decimals. These cases provide a baseline for measuring changes to precision validation and scaling behavior.
   
   # What changes are included in this PR?
   
   Add 16 cases covering successful safe/strict conversions, scaling, Decimal256 output, precision overflow, and non-finite floating-point inputs.
   
   Fixtures contain 8,192 unshredded Variant rows with approximately 10% nulls and a fixed RNG seed. They reuse the existing benchmark helper, with fixture construction outside timing.
   
   Float precision-overflow cases run before and after #11302, although their outputs differ: the fix replaces out-of-precision values with nulls.
   
   # Are these changes tested?
   
   This PR adds benchmarks only. All 16 cases were smoke-tested and measured against #11302 and its base. No library behavior changes or additional unit tests are included.
   
   # Are there any significant user-facing changes?
   
   No.
   
   # AI usage
   
   Developed with assistance from OpenAI Codex for implementation, validation, and this description.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Variant integer-to-decimal and float-to-decimal benchmarks [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #11416:
URL: https://github.com/apache/arrow-rs/pull/11416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Variant integer-to-decimal and float-to-decimal benchmarks [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #11416:
URL: https://github.com/apache/arrow-rs/pull/11416#issuecomment-6029176068

   thanks @sdf-jkl 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org