You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/05 16:26:53 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #11507:
[FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r403724706
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -845,21 +845,19 @@ public ExecutorService getAsyncOperationsThreadPool() {
private void notifyCheckpointComplete(long checkpointId) {
try {
- boolean success = actionExecutor.call(() -> {
Review comment:
Maybe I misunderstood the scope for `actionExecutor`? I thought it is only used for executing operations for non-task/mailbox thread for unification. And I checked all the usages for `performCheckpoint`, and it seems all from task thread execution. If it is called from barrier handler via `triggerCheckpointOnBarrier`, it should be still from task thread? If so we will not need to delegate it to `actionExecutor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services