You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "errose28 (via GitHub)" <gi...@apache.org> on 2026/08/12 17:47:40 UTC

[PR] HDDS-16154. Datanode should assign DatanodeDetails#currentVersion based on its apparent version [ozone]

errose28 opened a new pull request, #11006:
URL: https://github.com/apache/ozone/pull/11006

   **DRAFT** builds on #10994
   
   ## What changes were proposed in this pull request?
   
   `DatanodeDetails#currentVersion` is passed from Datanodes through SCM to clients to indicate the Datanode's server version. Once ZDU is finalized, this value should be the apparent version of the Datanode instead of a static software version. Additionally, `DatanodeDetails#currentVersion` is currently persisted into the Datanode's `datanode.id` yaml file, but never used. When Datanodes finalize, the current version they report to clients will increase, and this location will become stale. To keep it from diverging we should stop persisting this value in the `datanode.id` file.
   
   ## What is the link to the Apache JIRA
   
   HDDS-16154
   
   ## How was this patch tested?
   
   Unit tests added and updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16154. Datanode should assign DatanodeDetails#currentVersion based on its apparent version [ozone]

Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #11006:
URL: https://github.com/apache/ozone/pull/11006#issuecomment-5360171003

   Green CI on my [fork](https://github.com/errose28/ozone/actions/runs/32392702032/job/96505753382) with the last commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16154. Datanode should assign DatanodeDetails#currentVersion based on its apparent version [ozone]

Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #11006:
URL: https://github.com/apache/ozone/pull/11006#issuecomment-5347008230

   This is ready for review, just leaving as draft until CI on the latest commit goes through my fork. Thanks @ss77892 for the initial comments, they've been addressed here. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16154. Datanode should assign DatanodeDetails#currentVersion based on its apparent version [ozone]

Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #11006:
URL: https://github.com/apache/ozone/pull/11006#issuecomment-5297734394

   Link to relevant comments which I'll fix here:
   https://github.com/apache/ozone/pull/11025#issuecomment-5297637180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16154. Datanode should assign DatanodeDetails#currentVersion based on its apparent version [ozone]

Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel merged PR #11006:
URL: https://github.com/apache/ozone/pull/11006


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org