You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "MarianMacik (via GitHub)" <gi...@apache.org> on 2023/10/17 21:23:04 UTC
Re: [PR] [ #502 ] Fix URL given when uninstalling the operator and giving more info [incubator-kie-kogito-docs]
MarianMacik commented on code in PR #510:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/510#discussion_r1362797990
##########
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc:
##########
@@ -142,17 +147,18 @@ kubectl get deployment sonataflow-operator-controller-manager -n sonataflow-oper
quay.io/kiegroup/kogito-serverless-operator-nightly:1.41.0
----
-The operator manager image reflects the current operator's version. Replace the major and minor version names in the command below. For example, if the image version is `1.41.0` use `1.41` in the placeholder:
-
.Uninstalling the operator
+
[source,shell,subs="attributes+"]
----
-kubectl delete -f https://raw.githubusercontent.com/kiegroup/kogito-serverless-operator/<version>.x/operator.yaml
+kubectl delete -f https://raw.githubusercontent.com/kiegroup/kogito-serverless-operator/v<version>/operator.yaml
----
[TIP]
====
If you're running a snapshot version, use this URL instead `https://raw.githubusercontent.com/kiegroup/kogito-serverless-operator/main/operator.yaml`.
+
+The URL should be the same used when installing the operator
Review Comment:
```suggestion
The URL should be the same used when installing the operator.
```
##########
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc:
##########
@@ -1,4 +1,4 @@
-= Install the {operator_name}
+https://xxx[= Install the ]{operator_name}
Review Comment:
Probably a leftover?
```suggestion
= Install the {operator_name}
```
##########
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc:
##########
@@ -142,17 +147,18 @@ kubectl get deployment sonataflow-operator-controller-manager -n sonataflow-oper
quay.io/kiegroup/kogito-serverless-operator-nightly:1.41.0
----
-The operator manager image reflects the current operator's version. Replace the major and minor version names in the command below. For example, if the image version is `1.41.0` use `1.41` in the placeholder:
-
.Uninstalling the operator
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org