[GitHub] [helix] dasahcc opened a new pull request #569: Fix partitions double charged for pending message

[GitBox <gi...@apache.org>]

dasahcc opened a new pull request #569: Fix partitions double charged for pending message
URL: https://github.com/apache/helix/pull/569
 
 
   ### Issues
   
   - [X] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixes #568 
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   Current Helix will charge the partitions with pending message twice due to not remove the partition from partitions need recovery/load balance set when they are charged for pending message.
   
   This fix will fix the problem for recovery/load/ANY rebalance type charged for pending messages.
   
   ### Tests
   
   - [X] The following tests are written for this issue:
   Adding pending message piece for a partition.
   
   - [X] The following is the result of the "mvn test" command on the appropriate module:
   
   [ERROR] Failures: 
   [ERROR]   TestPartitionMovementThrottle.testResourceThrottle:162->getMaxParallelTransitionCount:376 » ConcurrentModification
   [ERROR]   TestTaskPerformanceMetrics.testTaskPerformanceMetrics:118 expected:<true> but was:<false>
   [ERROR]   TestGetLastScheduledTaskExecInfo.testGetLastScheduledTaskExecInfo:73 expected:<COMPLETED> but was:<RUNNING>
   [INFO] 
   [ERROR] Tests run: 882, Failures: 3, Errors: 0, Skipped: 1
   
   [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 77.865 s - in TestSuite
   [INFO] 
   [INFO] Results:
   [INFO] 
   [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
   
   
   ### Commits
   
   - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Code Quality
   
   - [X] My diff has been formatted using helix-style.xml
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org