You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/28 12:29:38 UTC
[GitHub] [pulsar] liangyepianzhou opened a new pull request #14911: [Fix][Transaction] Optimize log when create transaction systemTopic
liangyepianzhou opened a new pull request #14911:
URL: https://github.com/apache/pulsar/pull/14911
Fix https://github.com/apache/pulsar/issues/14790
### Motivation
When users use admin to get status of transaction system topic,they will get a confused error.
### Modification
Optimize the error msg.
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a change in pull request #14911: [Fix][Transaction] Optimize log when create transaction systemTopic
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #14911:
URL: https://github.com/apache/pulsar/pull/14911#discussion_r836474623
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1376,7 +1376,8 @@ private void createPersistentTopic(final String topic, boolean createIfMissing,
}
if (isTransactionSystemTopic(topicName)) {
- String msg = String.format("Can not create transaction system topic %s", topic);
+ String msg = String.format("Only has metadata, used for transactionCoordinator load balance, "
+ + "never need to be created, for transaction system topic %s", topic);
Review comment:
Ah...it's funny.
@Anonymitaet Could you help review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #14911: [Fix][Transaction] Optimize log when create transaction systemTopic
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #14911:
URL: https://github.com/apache/pulsar/pull/14911#discussion_r837009063
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1376,7 +1376,8 @@ private void createPersistentTopic(final String topic, boolean createIfMissing,
}
if (isTransactionSystemTopic(topicName)) {
- String msg = String.format("Can not create transaction system topic %s", topic);
+ String msg = String.format("Only has metadata, used for transactionCoordinator load balance, "
+ + "never need to be created, for transaction system topic %s", topic);
Review comment:
@liangyepianzhou Sorry, I don't quite understand the meaning. Could you please explain a bit more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14911: [Fix][Transaction] Optimize log when create transaction systemTopic
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on a change in pull request #14911:
URL: https://github.com/apache/pulsar/pull/14911#discussion_r837196882
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1376,7 +1376,8 @@ private void createPersistentTopic(final String topic, boolean createIfMissing,
}
if (isTransactionSystemTopic(topicName)) {
- String msg = String.format("Can not create transaction system topic %s", topic);
+ String msg = String.format("Only has metadata, used for transactionCoordinator load balance, "
+ + "never need to be created, for transaction system topic %s", topic);
Review comment:
Ignore creation of transaction system topic, no need to create. @Anonymitaet. I think the meaning is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #14911: [Fix][Transaction] Optimize log when create transaction systemTopic
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on a change in pull request #14911:
URL: https://github.com/apache/pulsar/pull/14911#discussion_r837042286
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1376,7 +1376,8 @@ private void createPersistentTopic(final String topic, boolean createIfMissing,
}
if (isTransactionSystemTopic(topicName)) {
- String msg = String.format("Can not create transaction system topic %s", topic);
+ String msg = String.format("Only has metadata, used for transactionCoordinator load balance, "
+ + "never need to be created, for transaction system topic %s", topic);
Review comment:
Of course, the current situation is that we have some system topics for lookup that only need to create metadata.
Then the user used admin to query this topic, but our error made the user confused and raised the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14911: [Fix][Transaction] Optimize log when create transaction systemTopic
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on a change in pull request #14911:
URL: https://github.com/apache/pulsar/pull/14911#discussion_r837196882
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1376,7 +1376,8 @@ private void createPersistentTopic(final String topic, boolean createIfMissing,
}
if (isTransactionSystemTopic(topicName)) {
- String msg = String.format("Can not create transaction system topic %s", topic);
+ String msg = String.format("Only has metadata, used for transactionCoordinator load balance, "
+ + "never need to be created, for transaction system topic %s", topic);
Review comment:
Ignore creation of transaction system topic, no need to create.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org