You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Elliotte Rusty Harold (Jira)" <ji...@apache.org> on 2019/12/19 12:08:00 UTC
[jira] [Updated] (WAGON-396) AbstractHttpClientWagon extensibility
(SPNEGO Authentication)
[ https://issues.apache.org/jira/browse/WAGON-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliotte Rusty Harold updated WAGON-396:
----------------------------------------
Description:
I recently implemented SPNEGO authentication for the wagon-http provider. This implementation required a extension of DefaultHttpClient. So far this support lives in a separate modules. Unfortunately overriding the client initialization is not easily possible in the current code and requires nearly full duplication of wagon-http code.
I would suggest to move the instantiation of the client from AbstractHttpClientWagon.openConnectionInternal() into a separate factory method, e.g.
{code}
protected DefaultHttpClient createHttpClient( ClientConnectionManager connManager ) {
return new DefaultHttpClient(connManager);
}
public void openConnectionInternal()
{
repository.setUrl( getURL( repository ) );
client = this.createHttpClient( getConnectionManager() );
{code}
In case you are interested to integrate the SPNEGO support, I will be happy to share.
was:
I recently implemented SPNEGO authentication for the wagon-http provider. This implementation required a extension of DefaultHttpClient. So far this support lives in a separate modules. Unfortunately overriding the client initialization is not easily possible in the current code and requires nearly full duplication of wagon-http code.
I would suggest to move the instantiation of the client from AbstractHttpClientWagon.openConnectionInternal() into a seperate factory method, e.g.
{code}
protected DefaultHttpClient createHttpClient( ClientConnectionManager connManager ) {
return new DefaultHttpClient(connManager);
}
public void openConnectionInternal()
{
repository.setUrl( getURL( repository ) );
client = this.createHttpClient( getConnectionManager() );
{code}
In case you are interested to integrate the SPNEGO support, I will be happy to share.
> AbstractHttpClientWagon extensibility (SPNEGO Authentication)
> -------------------------------------------------------------
>
> Key: WAGON-396
> URL: https://issues.apache.org/jira/browse/WAGON-396
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http
> Affects Versions: 2.5
> Reporter: Moritz Bechler
> Priority: Minor
>
> I recently implemented SPNEGO authentication for the wagon-http provider. This implementation required a extension of DefaultHttpClient. So far this support lives in a separate modules. Unfortunately overriding the client initialization is not easily possible in the current code and requires nearly full duplication of wagon-http code.
> I would suggest to move the instantiation of the client from AbstractHttpClientWagon.openConnectionInternal() into a separate factory method, e.g.
> {code}
> protected DefaultHttpClient createHttpClient( ClientConnectionManager connManager ) {
> return new DefaultHttpClient(connManager);
> }
> public void openConnectionInternal()
> {
> repository.setUrl( getURL( repository ) );
> client = this.createHttpClient( getConnectionManager() );
> {code}
> In case you are interested to integrate the SPNEGO support, I will be happy to share.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)