You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/17 02:43:44 UTC

[GitHub] [beam] MarcoRob opened a new pull request, #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

MarcoRob opened a new pull request, #23364:
URL: https://github.com/apache/beam/pull/23364

   As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:
   
   - Migrated workflow [job-precommit-python-runners-portability-spark.yml](https://github.com/apache/beam/blob/f46d489795ff68bbe5ed3c39b70015c6ce6a064e/.github/workflows/job-precommit-python-runners-portability-spark.yml)
   
   The migrated workflow was added to [CI.md](https://github.com/apache/beam/blob/f46d489795ff68bbe5ed3c39b70015c6ce6a064e/CI.md)
   
   `DO NOT MERGE` until the effort to use self-hosted runners is completed https://github.com/apache/beam/pull/22703
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] MarcoRob commented on a diff in pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

Posted by GitBox <gi...@apache.org>.
MarcoRob commented on code in PR #23364:
URL: https://github.com/apache/beam/pull/23364#discussion_r999969683


##########
.github/workflows/job-precommit-python-runners-portability-spark.yml:
##########
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test for Python Precommit Runners Portability Spark
+
+
+name: Python Precommit Runners Portability Spark
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 */6 * * *'
+  push:
+    branches: ['master', 'release-*']
+    tags: ['v*']
+    paths: [ 'sdks/python/apache_beam/runners/portability/spark_runner.py',
+             'sdks/python/apache_beam/runners/portability/spark_runner_test.py',
+             'sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server.py',
+             'sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server_test.py' ]

Review Comment:
   @damccorm same context, should we remove it? (considering this is a pre-commit job)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23364:
URL: https://github.com/apache/beam/pull/23364#issuecomment-1384007039

   This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm closed pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark
URL: https://github.com/apache/beam/pull/23364


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] MarcoRob commented on a diff in pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

Posted by GitBox <gi...@apache.org>.
MarcoRob commented on code in PR #23364:
URL: https://github.com/apache/beam/pull/23364#discussion_r1004816619


##########
.github/workflows/job-precommit-python-runners-portability-spark.yml:
##########
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test for Python Precommit Runners Portability Spark
+
+
+name: Python Precommit Runners Portability Spark
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 */6 * * *'
+  push:
+    branches: ['master', 'release-*']
+    tags: ['v*']
+    paths: [ 'sdks/python/apache_beam/runners/portability/spark_runner.py',
+             'sdks/python/apache_beam/runners/portability/spark_runner_test.py',
+             'sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server.py',
+             'sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server_test.py' ]

Review Comment:
   Hi @damccorm is there any comment on this? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23364:
URL: https://github.com/apache/beam/pull/23364#issuecomment-1278925686

   Reminder, please take a look at this pr: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23364:
URL: https://github.com/apache/beam/pull/23364#issuecomment-1475243170

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23364:
URL: https://github.com/apache/beam/pull/23364#issuecomment-1375574686

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23364:
URL: https://github.com/apache/beam/pull/23364#discussion_r1018165384


##########
.github/workflows/job-precommit-python-runners-portability-spark.yml:
##########
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test for Python Precommit Runners Portability Spark
+
+
+name: Python Precommit Runners Portability Spark
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 */6 * * *'
+  push:
+    branches: ['master', 'release-*']
+    tags: ['v*']
+    paths: [ 'sdks/python/apache_beam/runners/portability/spark_runner.py',
+             'sdks/python/apache_beam/runners/portability/spark_runner_test.py',
+             'sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server.py',
+             'sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server_test.py' ]

Review Comment:
   This is fine as is, my mistake



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23364:
URL: https://github.com/apache/beam/pull/23364#discussion_r995941508


##########
.github/workflows/job-precommit-python-runners-portability-spark.yml:
##########
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test for Python Precommit Runners Portability Spark
+
+
+name: Python Precommit Runners Portability Spark
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 */6 * * *'
+  push:
+    branches: ['master', 'release-*']
+    tags: ['v*']
+    paths: [ 'sdks/python/apache_beam/runners/portability/spark_runner.py',
+             'sdks/python/apache_beam/runners/portability/spark_runner_test.py',
+             'sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server.py',
+             'sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server_test.py' ]

Review Comment:
   We should run postcommits on all paths, please remove these



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23364:
URL: https://github.com/apache/beam/pull/23364#issuecomment-1270189441

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] closed pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #23364: GA Migration Python PreCommit Sharding Runners Portability Spark
URL: https://github.com/apache/beam/pull/23364


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org