You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/08/25 09:45:29 UTC

[GitHub] [commons-exec] ArdenL-Liu opened a new pull request, #61: CommandLine.toCleanExecutable(final String dirtyExecutable) should throw IllegalArgumentException If dirtyExecutable is null or empty

ArdenL-Liu opened a new pull request, #61:
URL: https://github.com/apache/commons-exec/pull/61

   CommandLine.toCleanExecutable(final String dirtyExecutable) should throw IllegalArgumentException If dirtyExecutable is null or empty
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-exec] ArdenL-Liu commented on a diff in pull request #61: [Javadoc] CommandLine.toCleanExecutable(final String dirtyExecutable) IllegalArgumentException

Posted by GitBox <gi...@apache.org>.
ArdenL-Liu commented on code in PR #61:
URL: https://github.com/apache/commons-exec/pull/61#discussion_r979508469


##########
src/main/java/org/apache/commons/exec/CommandLine.java:
##########
@@ -398,6 +398,7 @@ private static String[] translateCommandline(final String toProcess) {
      *
      * @param dirtyExecutable the executable
      * @return the platform-specific executable string
+     * @throws IllegalArgumentException If dirtyExecutable is null or empty

Review Comment:
   Hi garydgregory,
   I reviewed CommandLine.java  again, and added the javadoc to the constructor CommandLine(String).
   you can review it.
   thanks.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Javadoc] CommandLine.toCleanExecutable(final String dirtyExecutable) IllegalArgumentException [commons-exec]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #61:
URL: https://github.com/apache/commons-exec/pull/61#issuecomment-1872181460

   Closing: Done in git master. You are credited in `change.xml`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Javadoc] CommandLine.toCleanExecutable(final String dirtyExecutable) IllegalArgumentException [commons-exec]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #61: [Javadoc] CommandLine.toCleanExecutable(final String dirtyExecutable) IllegalArgumentException
URL: https://github.com/apache/commons-exec/pull/61


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-exec] garydgregory commented on a diff in pull request #61: [Javadoc] CommandLine.toCleanExecutable(final String dirtyExecutable) IllegalArgumentException

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #61:
URL: https://github.com/apache/commons-exec/pull/61#discussion_r978954072


##########
src/main/java/org/apache/commons/exec/CommandLine.java:
##########
@@ -398,6 +398,7 @@ private static String[] translateCommandline(final String toProcess) {
      *
      * @param dirtyExecutable the executable
      * @return the platform-specific executable string
+     * @throws IllegalArgumentException If dirtyExecutable is null or empty

Review Comment:
   Hello @ArdenL-Liu 
   Thank you for your PR.
   You might as well update the other Javadoc instances in this class where IllegalArgumentException is thrown but not documented, especially since we seem to document some but not all cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org