You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ocadaruma (via GitHub)" <gi...@apache.org> on 2023/10/09 15:02:30 UTC

[PR] KAFKA-15567 Fix benchmark code to work [kafka]

ocadaruma opened a new pull request, #14513:
URL: https://github.com/apache/kafka/pull/14513

   ## Summary
   
   - Currently, ReplicaFetcherThreadBenchmark doesn't run due to 2 reasons:
     * NPE that is introduced by https://github.com/apache/kafka/commit/755e04a41dfd00dd4587b0fe0980befd0ae5c433
         - ZkMetadataCache instantiation causes NPE because we pass `null` for `kraftControllerNodes` but it should be `Seq.empty`
     * NotLeaderOrFollowerException that is introduced by https://github.com/apache/kafka/commit/3467036e017adc3ac0919bbc0c067b1bb1b621f3
         - Even we address above NPE issue, we still get NotLeaderOrFollowerException
         - ```
           org.apache.kafka.common.errors.NotLeaderOrFollowerException: Error while fetching partition state for topic-30
           ```
         - This is because replicaManager doesn't host partitions when RemoteLeaderEndPoint tries to build fetches
   - This PR addresses these problems
   - NPE issue on ZkMetadataCache instantiation also occurs in other several benchmarks. This PR also fix these benchmarks.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-15567 Fix benchmark code to work [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14513:
URL: https://github.com/apache/kafka/pull/14513#issuecomment-1882343262

   This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has  merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-15567 Fix benchmark code to work [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #14513: KAFKA-15567 Fix benchmark code to work
URL: https://github.com/apache/kafka/pull/14513


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-15567 Fix benchmark code to work [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14513:
URL: https://github.com/apache/kafka/pull/14513#issuecomment-2568654635

   This PR has been closed since it has not had any activity in 120 days. If you feel like this
   was a mistake, or you would like to continue working on it, please feel free to re-open the 
   PR and ask for a review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org