You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/11/18 20:25:19 UTC
[GitHub] [maven-assembly-plugin] gnodet opened a new pull request #38: MASSEMBLY-945 - speed improvements
gnodet opened a new pull request #38:
URL: https://github.com/apache/maven-assembly-plugin/pull/38
This PR only makes sense with
https://github.com/codehaus-plexus/plexus-utils/pull/106
https://github.com/codehaus-plexus/plexus-io/pull/33
https://github.com/codehaus-plexus/plexus-archiver/pull/157
https://github.com/apache/maven-common-artifact-filters/pull/15
... but if I add the snapshot upgrades, the checks won't pass anymore ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] bmarwell commented on pull request #38: MASSEMBLY-945 - speed improvements
Posted by GitBox <gi...@apache.org>.
bmarwell commented on pull request #38:
URL: https://github.com/apache/maven-assembly-plugin/pull/38#issuecomment-742501964
> Far more often than not, microoptimizations like this result in no measurable impact. All claims of performance improvements need numbers.
https://github.com/codehaus-plexus/plexus-io/pull/33#discussion_r530614310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] gnodet commented on pull request #38: MASSEMBLY-945 - speed improvements
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #38:
URL: https://github.com/apache/maven-assembly-plugin/pull/38#issuecomment-742507321
The speed gain may be negligible for this PR, it does not matter much.
However, I'd like the other PR referenced above to get merged, so that we can upgrade to those new versions to have a *non negligible* performance gain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] olamy merged pull request #38: MASSEMBLY-945 - speed improvements
Posted by GitBox <gi...@apache.org>.
olamy merged pull request #38:
URL: https://github.com/apache/maven-assembly-plugin/pull/38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] elharo commented on pull request #38: MASSEMBLY-945 - speed improvements
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #38:
URL: https://github.com/apache/maven-assembly-plugin/pull/38#issuecomment-739920167
have you measured the improvements? if so, what are the numbers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] bmarwell commented on pull request #38: MASSEMBLY-945 - speed improvements
Posted by GitBox <gi...@apache.org>.
bmarwell commented on pull request #38:
URL: https://github.com/apache/maven-assembly-plugin/pull/38#issuecomment-739924424
> have you measured the improvements? if so, what are the numbers?
Null-length arrays are known to be faster since at least 2013 iirc.
* https://shipilev.net/blog/2016/arrays-wisdom-ancients/ (updated 2016)
* https://stackoverflow.com/a/29444594/1549977 (from 2013)
In my opinion measurements are not needed here because of this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] eolivelli commented on pull request #38: MASSEMBLY-945 - speed improvements
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #38:
URL: https://github.com/apache/maven-assembly-plugin/pull/38#issuecomment-743156929
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] elharo commented on pull request #38: MASSEMBLY-945 - speed improvements
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #38:
URL: https://github.com/apache/maven-assembly-plugin/pull/38#issuecomment-740008378
Far more often than not, microoptimizations like this result in no measurable impact. All claims of performance improvements need numbers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org