You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/18 12:54:36 UTC
[GitHub] [maven-mvnd] ppalaga opened a new pull request, #721: Fixup #716 Calculate java home from java command
ppalaga opened a new pull request, #721:
URL: https://github.com/apache/maven-mvnd/pull/721
* Add a test
* Simplify the stream processing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] ppalaga commented on a diff in pull request #721: Fixup #716 Calculate java home from java command
Posted by GitBox <gi...@apache.org>.
ppalaga commented on code in PR #721:
URL: https://github.com/apache/maven-mvnd/pull/721#discussion_r998644823
##########
client/src/main/java/org/mvndaemon/mvnd/client/DaemonParameters.java:
##########
@@ -150,8 +150,11 @@ public Path javaHome() {
}
}
- private String javaHomeFromPath() {
- final String jHome = OsUtils.findJavaHomeFromPath();
+ private static String javaHomeFromPath() {
+ LOG.warn("Falling back to finding JAVA_HOME by running java executable available in PATH."
Review Comment:
> why warn here? the generic java version (mvnd.sh) will also search java from path without a warning
As long as I am on an OS and arch having a mvnd native executable, I do not need to care that mvnd.sh is slow. mvnd.sh is fallback where some expectations are not met. But actually we could warn in mvnd.sh too. I'd prefer knowing that mvnd is missing some piece of config that makes it slower.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] gzm55 commented on a diff in pull request #721: Fixup #716 Calculate java home from java command
Posted by GitBox <gi...@apache.org>.
gzm55 commented on code in PR #721:
URL: https://github.com/apache/maven-mvnd/pull/721#discussion_r998300127
##########
client/src/main/java/org/mvndaemon/mvnd/client/DaemonParameters.java:
##########
@@ -150,8 +150,11 @@ public Path javaHome() {
}
}
- private String javaHomeFromPath() {
- final String jHome = OsUtils.findJavaHomeFromPath();
+ private static String javaHomeFromPath() {
+ LOG.warn("Falling back to finding JAVA_HOME by running java executable available in PATH."
Review Comment:
why warn here? the generic java version (mvnd.sh) will also search java from path without a warning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] gnodet merged pull request #721: Fixup #716 Calculate java home from java command
Posted by GitBox <gi...@apache.org>.
gnodet merged PR #721:
URL: https://github.com/apache/maven-mvnd/pull/721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org