[GitHub] [accumulo] dlmarion commented on a change in pull request #2554: Allow UncaughtExceptionHandler to be overridden in client

[GitBox <gi...@apache.org>]

dlmarion commented on a change in pull request #2554:
URL: https://github.com/apache/accumulo/pull/2554#discussion_r822609941



##########
File path: core/src/main/java/org/apache/accumulo/core/client/AccumuloClient.java
##########
@@ -346,6 +347,16 @@ ConditionalWriter createConditionalWriter(String tableName, ConditionalWriterCon
    */
   interface ClientFactory<T> {
 
+    /**
+     * Override default handling of uncaught exceptions in client threads
+     *
+     * @param ueh
+     *          UncaughtExceptionHandler implementation
+     * @return AccumuloClient or Properties
+     * @since 2.1.0
+     */
+    ClientFactory<T> withUncaughtExceptionHandler(Class<? extends UncaughtExceptionHandler> ueh);

Review comment:
       With the code the way that it is, would it allow a user to put the class name in the client properties file? If so, then doing it this way would preclude that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org