You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/17 03:18:50 UTC
[GitHub] [arrow] westonpace opened a new pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
westonpace opened a new pull request #12446:
URL: https://github.com/apache/arrow/pull/12446
Ubuntu 18.04 does not have a new enough version of protobuf to use the engine module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042864652
Since Substrait is AFAIK still just a draft, this would be a good reason to try and switch it to Flatbuffers, IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten edited a comment on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten edited a comment on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042862214
I've already modified the Susbtrait consumer sources to work all the way down to 3.0.0 with minimal effort. It's merely a bit annoying. Alternative PR incoming. -> #12448
@pitrou Unfortunately, no. The files protoc generates demand exactly the same version of libprotobuf or they will refuse to compile, and in general only one version of libprotobuf can be linked in an application/library (even with private static linking tricks) because the library has global state and no ability to namespace anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042862214
I've already modified the Susbtrait consumer sources to work all the way down to 3.0.0 with minimal effort. It's merely a bit annoying. Alternative PR incoming.
@pitrou Unfortunately, no. The files protoc generates demand exactly the same version of libprotobuf or they will refuse to compile, and in general only one version of libprotobuf can be linked in an application/library (even with private static linking tricks) because the library has global state and no ability to namespace anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042884516
PR for support down to libprotobuf 3.0.0 at #12448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042532226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten edited a comment on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten edited a comment on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042871284
That'd basically be starting over from scratch, when DuckDB already has a working extension for Substrait merged in to their main branch, there's lots of work already in progress for Ibis, there's obviously the Arrow consumer that would have to be completely rewritten, etc. I wouldn't call it "just a draft" anymore.
What we could consider doing if this continues to be a problem is switch to an alternative protobuf library, like [upb](https://github.com/protocolbuffers/upb), but that'd probably also be a rewrite on our end. I suppose we could even fork protobuf to just add namespacing support (if no one else has done so already). I can't imagine that being very difficult, but it's obviously maintenance work (assuming Google doesn't want to merge it in). But maybe that's a bit naive of me.
ETA: oh, it looks like upb isn't intended to be used within C(++) directly. So maybe not the best choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042536407
Revision: 87bdd53eb3236c527352e3f182f68d32d6b42096
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1644](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1644)
|Task|Status|
|----|------|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1644-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1644-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1644-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace closed pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
westonpace closed pull request #12446:
URL: https://github.com/apache/arrow/pull/12446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042920849
We could look into alternative Protobuf implementations for this use case, since we don't need the gRPC code generator. Presumably something like nanopb could be fully vendored and would not conflict with downstream usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042790784
Would it be reasonable to vendor the generated files instead? @lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1043267577
I'm abandoning this in favor of #12448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042881138
Yes, I don't think we want to fork protobuf :-) Well, it's a pity if Substrait considers its choice done, even though there are few convincing reasons for protobuf over flatbuffers (I think the main one is that protobuf is _a bit more_ ubiquitous, but there are also flatbuffers implementations for many languages, and Arrow didn't have a problem with it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042921472
But yes, as Jeroen points out, the Google Protobuf implementation is really built around a monorepo assumption where you are in full control of all code being built and so compatibility, vendoring, etc. are not really concerns…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042533278
@github-actions crossbow submit test-ubuntu-*-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on pull request #12446: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042871284
That'd basically be starting over from scratch, when DuckDB already has a working extension for Substrait merged in to their main branch, there's lots of work already in progress for Ibis, there's obviously the Arrow consumer that would have to be completely rewritten, etc. I wouldn't call it "just a draft" anymore.
What we could consider doing if this continues to be a problem is switch to an alternative protobuf library, like [upb](https://github.com/protocolbuffers/upb), but that'd probably also be a rewrite on our end. I suppose we could even fork protobuf to just add namespacing support (if no one else has done so already). I can't imagine that being very difficult, but it's obviously maintenance work (assuming Google doesn't want to merge it in). But maybe that's a bit naive of me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org