You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/04 06:45:04 UTC
[GitHub] [airflow] Bowrna opened a new pull request #21986: added docker network_mode options in documentation
Bowrna opened a new pull request #21986:
URL: https://github.com/apache/airflow/pull/21986
closes: #8418
related: #8418
Added documentation for Docker operator network_mode option.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on a change in pull request #21986: added docker network_mode options in documentation
Posted by GitBox <gi...@apache.org>.
Bowrna commented on a change in pull request #21986:
URL: https://github.com/apache/airflow/pull/21986#discussion_r819306536
##########
File path: airflow/providers/docker/operators/docker.py
##########
@@ -90,6 +90,12 @@ class DockerOperator(BaseOperator):
:param host_tmp_dir: Specify the location of the temporary directory on the host which will
be mapped to tmp_dir. If not provided defaults to using the standard system temp directory.
:param network_mode: Network mode for the container.
+ It can be one of the following:
+ bridge - Create new network stack for the container with default docker bridge network
+ None - No networking for this container
+ container:<name|id> - Use the network stack of another container specified via <name|id>
+ host - Use the host network stack. Incompatible with `port_bindings`
Review comment:
In host network stack, `port_binding` option is incompatible as container and it's host shares same networking namespace and the container has the same IP address as that of the host. However in `create_host_config` function in DockerOperator we don't support port_binding as param. So I am not sure if we have to add this detail `Incompatible with port_bindings` in the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21986: added docker network_mode options in documentation
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21986:
URL: https://github.com/apache/airflow/pull/21986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org