You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/19 10:37:16 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #6105: arch/clang: add support for Clang LTO
anchao opened a new pull request, #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105
## Summary
arch/clang: add support for Clang LTO
add support of Clang's Link Time Optimization (LTO) on NuttX build system
Reference:
https://llvm.org/docs/LinkTimeOptimization.html
Signed-off-by: chao.an <an...@xiaomi.com>
## Impact
Clang + LTO
## Testing
1. Code Size
2. Coremark
3. LVGL BenchMark
Weighted FPS
All Cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6105: arch/clang: add support for Clang LTO
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #6105: arch/clang: add support for Clang LTO
Posted by GitBox <gi...@apache.org>.
anchao commented on PR #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105#issuecomment-1102488930
Depends on: https://github.com/apache/incubator-nuttx/pull/6097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6105: arch/clang: add support for Clang LTO
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105#discussion_r853221671
##########
arch/Kconfig:
##########
@@ -222,6 +222,57 @@ config ARCH_TOOLCHAIN_GNU
bool
default n
+config ARCH_TOOLCHAIN_CLANG
Review Comment:
let's add a new patch to support clang on armv6-m too.
##########
arch/arm/src/armv8-m/Toolchain.defs:
##########
@@ -65,6 +65,12 @@ else
MAXOPTIMIZATION ?= -Os
endif
+ifeq ($(CONFIG_LTO_CLANG_THIN),y)
Review Comment:
let's move to clang specific section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6105: arch/clang: add support for Clang LTO
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105#issuecomment-1102502498
@anchao have you tried GCC `Os` + `lto`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #6105: arch/clang: add support for Clang LTO
Posted by GitBox <gi...@apache.org>.
anchao commented on PR #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105#issuecomment-1102575346
> @anchao have you tried GCC `Os` + `lto`?
Not yet, will add gcc lto + link plugin support later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6105: arch/clang: add support for Clang LTO
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105#discussion_r854234212
##########
arch/Kconfig:
##########
@@ -222,6 +222,49 @@ config ARCH_TOOLCHAIN_GNU
bool
default n
+config ARCH_TOOLCHAIN_CLANG
+ bool
+ select ARCH_TOOLCHAIN_GNU
+ default n
+
+choice
+ prompt "Link Time Optimization (LTO)"
+ default LTO_NONE
+ ---help---
+ This option enables Link Time Optimization (LTO), which allows the
+ compiler to optimize binaries globally.
+
+ If unsure, select LTO_NONE. Note that LTO is very resource-intensive
+ so it's disabled by default.
+
+config LTO_NONE
+ bool "None"
+ help
+ Build the kernel normally, without Link Time Optimization (LTO).
Review Comment:
please use TABs only in Kconfig files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #6105: arch/clang: add support for Clang LTO
Posted by GitBox <gi...@apache.org>.
anchao commented on PR #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105#issuecomment-1106015800
> > @anchao have you tried GCC `Os` + `lto`?
>
> Not yet, will add gcc lto + link plugin support later
Update performance profiling data of GCC lto on below PR:
https://github.com/apache/incubator-nuttx/pull/6123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6105: arch/clang: add support for Clang LTO
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105#discussion_r854170140
##########
arch/arm/src/armv8-m/Toolchain.defs:
##########
@@ -65,6 +65,12 @@ else
MAXOPTIMIZATION ?= -Os
endif
+ifeq ($(CONFIG_LTO_CLANG_THIN),y)
Review Comment:
Done
##########
arch/Kconfig:
##########
@@ -222,6 +222,57 @@ config ARCH_TOOLCHAIN_GNU
bool
default n
+config ARCH_TOOLCHAIN_CLANG
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6105: arch/clang: add support for Clang LTO
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105#discussion_r854239457
##########
arch/Kconfig:
##########
@@ -222,6 +222,49 @@ config ARCH_TOOLCHAIN_GNU
bool
default n
+config ARCH_TOOLCHAIN_CLANG
+ bool
+ select ARCH_TOOLCHAIN_GNU
+ default n
+
+choice
+ prompt "Link Time Optimization (LTO)"
+ default LTO_NONE
+ ---help---
+ This option enables Link Time Optimization (LTO), which allows the
+ compiler to optimize binaries globally.
+
+ If unsure, select LTO_NONE. Note that LTO is very resource-intensive
+ so it's disabled by default.
+
+config LTO_NONE
+ bool "None"
+ help
+ Build the kernel normally, without Link Time Optimization (LTO).
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6105: arch/clang: add support for Clang LTO
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105#issuecomment-1103249944
@anchao
I think the results are very interesting.
Please add descriptions such as CPU arch and board config to the summary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #6105: arch/clang: add support for Clang LTO
Posted by GitBox <gi...@apache.org>.
anchao commented on PR #6105:
URL: https://github.com/apache/incubator-nuttx/pull/6105#issuecomment-1103463134
> @anchao
>
> I think the results are very interesting. Please add descriptions such as CPU arch and board config to the summary.
@masayuki2009 architecture information and board config has been updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org