You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ji...@apache.org on 2017/12/06 08:01:31 UTC

lucene-solr:master: LUCENE-8079: Fix test bug

Repository: lucene-solr
Updated Branches:
  refs/heads/master 071d9270d -> 32ffea6f2


LUCENE-8079: Fix test bug


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/32ffea6f
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/32ffea6f
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/32ffea6f

Branch: refs/heads/master
Commit: 32ffea6f2eefa892a9692ddd0815cbc0d8eea4bd
Parents: 071d927
Author: Jim Ferenczi <ji...@apache.org>
Authored: Wed Dec 6 09:01:21 2017 +0100
Committer: Jim Ferenczi <ji...@apache.org>
Committed: Wed Dec 6 09:01:21 2017 +0100

----------------------------------------------------------------------
 .../lucene/search/TestTopFieldCollectorEarlyTermination.java       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/32ffea6f/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
----------------------------------------------------------------------
diff --git a/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java b/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
index f225d0c..4b891de 100644
--- a/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
+++ b/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
@@ -154,7 +154,7 @@ public class TestTopFieldCollectorEarlyTermination extends LuceneTestCase {
         TopDocs td2 = collector2.topDocs();
 
         assertFalse(collector1.isEarlyTerminated());
-        if (trackMaxScore == false && paging == false && maxSegmentSize >= numHits && query instanceof MatchAllDocsQuery) {
+        if (trackMaxScore == false && paging == false && maxSegmentSize > numHits && query instanceof MatchAllDocsQuery) {
           // Make sure that we sometimes early terminate
           assertTrue(collector2.isEarlyTerminated());
         }


Re: lucene-solr:master: LUCENE-8079: Fix test bug

Posted by Adrien Grand <jp...@gmail.com>.
Thanks Jim!

Le mer. 6 déc. 2017 à 09:01, <ji...@apache.org> a écrit :

> Repository: lucene-solr
> Updated Branches:
>   refs/heads/master 071d9270d -> 32ffea6f2
>
>
> LUCENE-8079: Fix test bug
>
>
> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
> Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/32ffea6f
> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/32ffea6f
> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/32ffea6f
>
> Branch: refs/heads/master
> Commit: 32ffea6f2eefa892a9692ddd0815cbc0d8eea4bd
> Parents: 071d927
> Author: Jim Ferenczi <ji...@apache.org>
> Authored: Wed Dec 6 09:01:21 2017 +0100
> Committer: Jim Ferenczi <ji...@apache.org>
> Committed: Wed Dec 6 09:01:21 2017 +0100
>
> ----------------------------------------------------------------------
>  .../lucene/search/TestTopFieldCollectorEarlyTermination.java       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/32ffea6f/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
> ----------------------------------------------------------------------
> diff --git
> a/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
> b/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
> index f225d0c..4b891de 100644
> ---
> a/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
> +++
> b/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
> @@ -154,7 +154,7 @@ public class TestTopFieldCollectorEarlyTermination
> extends LuceneTestCase {
>          TopDocs td2 = collector2.topDocs();
>
>          assertFalse(collector1.isEarlyTerminated());
> -        if (trackMaxScore == false && paging == false && maxSegmentSize
> >= numHits && query instanceof MatchAllDocsQuery) {
> +        if (trackMaxScore == false && paging == false && maxSegmentSize >
> numHits && query instanceof MatchAllDocsQuery) {
>            // Make sure that we sometimes early terminate
>            assertTrue(collector2.isEarlyTerminated());
>          }
>
>