You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2012/10/06 23:19:02 UTC

[jira] [Commented] (HTTPCORE-311) Retrieval of primitive connection pool stat values

    [ https://issues.apache.org/jira/browse/HTTPCORE-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471097#comment-13471097 ] 

Oleg Kalnichevski commented on HTTPCORE-311:
--------------------------------------------

Seth,
You might want to contribute to HTTPCLIENT-1246 as an alternative to the proposed changes.

Oleg 
                
> Retrieval of primitive connection pool stat values
> --------------------------------------------------
>
>                 Key: HTTPCORE-311
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-311
>             Project: HttpComponents HttpCore
>          Issue Type: New Feature
>          Components: HttpCore
>    Affects Versions: 4.2.1
>            Reporter: Seth Weiner
>         Attachments: httpcomponents-monitoring-patch2.diff, httpcomponents-monitoring-patch3.diff, httpcomponents-monitoring-patch.diff, PollingPrimitivePoolControl.java, PollingPrimitivePoolControlTest.java, PrimitiveConnPoolControl.java
>
>
> The org.apache.http.pool.ConnPoolControl interface exposes valuable runtime metrics for a connection pool's individual routes and global values. However, it uses a bean class, org.apache.http.pool.PoolStats, to exposes the global values. This is problematic when trying to monitor these connection pool values at runtime since PoolStats is not Serializable and many jmx monitoring agents only support primitive values well. The value of the PoolStats class seems to be in trying to minimize the amount of locking of the pool required to get stats.
> The attached patch includes an interface that extends ConnPoolControl to add four methods to return the primitive value for global pool stats. There's an implementation of this interface that will delegate all of the ConnPoolControl methods to a delegate instance, and support retrieving the primitive global values by periodically retrieving and caching a PoolStats instance internally. This minimizes the amount of locking required while also making it easy to monitor these values.
> It would probably be ideal to incorporate this functionality directly into the existing ConnPoolControl interface, but the attached code provides a non-invasive way to achieve the desired effect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org