[GitHub] vylc commented on issue #4981: Make time filter more usable

[GitBox <gi...@apache.org>]

vylc commented on issue #4981: Make time filter more usable
URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391450331
 
 
   Looks great!
   (1) I like the organization that @elibrumbaugh suggested. Can we name the tab "Relative" vs. Defaults. Custom is good.
   (2) Re: the inclusive/exclusive that @michellethomas brought up, I think that belongs in an info hover as opposed to trying to name the fields accordingly
   (3) Ok/Cancel are good.  @GabeLoins do you want to adopt this as well for your metric popover (vs. Save/Close)? For consistency, I'd also move your buttons to the lower right since that's more natural than over to the lower left. Cancel (no color) should be to the left of OK (teal superset color)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org