You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/07/02 03:46:34 UTC
[GitHub] [kylin] zzcclp opened a new pull request #1301: KYLIN-4617 Check whether project/jobid exists before download diagnosis package
zzcclp opened a new pull request #1301:
URL: https://github.com/apache/kylin/pull/1301
When download diagnosis package, it's better to check whether project/jobid exists, if not, it raise a BadRequestException with XXX doesn't exist instead of NPE.
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1301: KYLIN-4617 Check whether project/jobid exists before download diagnosis package
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1301:
URL: https://github.com/apache/kylin/pull/1301
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1301: KYLIN-4617 Check whether project/jobid exists before download diagnosis package
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1301:
URL: https://github.com/apache/kylin/pull/1301#issuecomment-653849651
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1301: KYLIN-4617 Check whether project/jobid exists before download diagnosis package
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1301:
URL: https://github.com/apache/kylin/pull/1301#issuecomment-652794654
## Pull Request Test Coverage Report for [Build 6094](https://coveralls.io/builds/31817645)
* **0** of **31** **(0.0%)** changed or added relevant lines in **5** files are covered.
* **14** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.02%**) to **27.959%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [server-base/src/main/java/org/apache/kylin/rest/controller/DiagnosisController.java](https://coveralls.io/builds/31817645/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FDiagnosisController.java#L82) | 0 | 2 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/msg/CnMessage.java](https://coveralls.io/builds/31817645/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fmsg%2FCnMessage.java#L408) | 0 | 2 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/msg/Message.java](https://coveralls.io/builds/31817645/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fmsg%2FMessage.java#L421) | 0 | 2 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/util/AclEvaluate.java](https://coveralls.io/builds/31817645/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FAclEvaluate.java#L64) | 0 | 12 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/service/DiagnosisService.java](https://coveralls.io/builds/31817645/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FDiagnosisService.java#L88) | 0 | 13 | 0.0%
<!-- | **Total:** | **0** | **31** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/31817645/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42) | 1 | 83.33% |
| [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/31817645/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L58) | 4 | 60.0% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/31817645/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L193) | 9 | 76.29% |
<!-- | **Total:** | **14** | | -->
| Totals | [](https://coveralls.io/builds/31817645) |
| :-- | --: |
| Change from base [Build 6065](https://coveralls.io/builds/31633725): | -0.02% |
| Covered Lines: | 26101 |
| Relevant Lines: | 93354 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org