You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2007/11/28 01:50:15 UTC

DO NOT REPLY [Bug 43979] New: - Add abstraction for Java and Classfile output

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43979>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979

           Summary: Add abstraction for Java and Classfile output
           Product: Tomcat 6
           Version: 6.0.14
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Jasper
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: fmeschbe@day.com


In the incubating project Sling, we are using Jasper to compile JSP scripts
which are located in a JCR repository (e.g. Apache Jackrabbit). This may
perfectly be done using a customized ServletContext.

Likewise we would like to store the generated Java source files as well as the
generated class files in the same repository for later consumption. By storing
the Java and class files in the repository, we are able to remotely inspect the
java files in case of spurious issues or to remove the generated files
alltogether during development. In addition, we are thinking of distributing
generated class files between repositories in distributed or staged environments.

Upto now we have been working on a private patched version of Jasper 5.5.20, but
are not able to keep up with more recent Jasper releases. So we wonder whether
it would be possible to include this functionality into the Jasper release.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43979>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979





------- Additional Comments From fmeschbe@day.com  2007-11-27 16:54 -------
Created an attachment (id=21199)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21199&action=view)
Patch implementing the proposed IO abstraction

Appending a patch implementing the proposal of abstracting the output. The
abstraction also contains an input case, which replaces several uses of File
for reading in Jasper.

Finally, this patch also fixes a minor inconvenience, where classloaders are
cast to URLClassLoader without type checking thus potentially throwing
ClassCastExceptions.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43979>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979


fmeschbe@day.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21199|0                           |1
        is obsolete|                            |




------- Additional Comments From fmeschbe@day.com  2007-11-29 06:01 -------
(From update of attachment 21199)
Replacing patch with a new version


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43979>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979


fmeschbe@day.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21205|0                           |1
        is obsolete|                            |




------- Additional Comments From fmeschbe@day.com  2007-11-30 05:37 -------
(From update of attachment 21205)
Found some issues with the patch: The Compiler still refers to the filesystem
directly in some places and the default IOProvider.mkdirs method returns false
if the directory already exists


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43979>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979





------- Additional Comments From fmeschbe@day.com  2007-11-29 06:03 -------
Created an attachment (id=21205)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21205&action=view)
Patch implementing the proposed IO abstraction

New patch without all the reformattings.

Sorry, didn't remember all my Eclipse Save Actions ...

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43979>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979





------- Additional Comments From fmeschbe@day.com  2007-12-04 05:35 -------
Created an attachment (id=21225)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21225&action=view)
Patch implementing the proposed IO abstraction

New patch removing commented block in SmapFile

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43979>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979





------- Additional Comments From jfclere@gmail.com  2007-11-29 05:19 -------
Your patch contains a lot of style correction that makes difficult to see what
is really changed. Could please attach a patch without the style corrections?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43979>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979


fmeschbe@day.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21209|0                           |1
        is obsolete|                            |




------- Additional Comments From fmeschbe@day.com  2007-12-04 05:34 -------
(From update of attachment 21209)
Adding new patch removing the big commented block in the SmapFile class


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43979>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979





------- Additional Comments From fmeschbe@day.com  2007-11-30 05:39 -------
Created an attachment (id=21209)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21209&action=view)
Patch implementing the proposed IO abstraction

Fixed the mentioned issues:
   - Removed remaining direct filesystem references where appropriate
   - Default IOProvider.mkdirs now returns true if the directory exists or if
     it can be created

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org