[GitHub] [pinot] walterddr commented on a diff in pull request #9885: Fix issues for realtime table reload

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9885:
URL: https://github.com/apache/pinot/pull/9885#discussion_r1036602848


##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -210,40 +209,38 @@ private InstanceResponseBlock executeInternal(ServerQueryRequest queryRequest, E
     }
 
     // Gather stats for realtime consuming segments
+    // TODO: the freshness time should not be collected at query time because there is no guarantee that the consuming
+    //       segment is queried (consuming segment might be pruned, or the server only contains relocated committed
+    //       segments)

Review Comment:
   CC @vvivekiyer ^



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org