You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/09 18:28:00 UTC
[jira] [Commented] (HADOOP-14128) ChecksumFs should override rename
with overwrite flag
[ https://issues.apache.org/jira/browse/HADOOP-14128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246215#comment-16246215 ]
ASF GitHub Bot commented on HADOOP-14128:
-----------------------------------------
GitHub user mchataigner opened a pull request:
https://github.com/apache/hadoop/pull/290
HADOOP-14128. fix renameInternal in ChecksumFs
AbstractFs.rename(source, destination, options) calls
renameInternal(source, destination, overwrite)
This patch adds this method to ChecksumFs to rename the crc file in
addition to the file itself to avoid crc missmatch when use for example
in LocalFs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mchataigner/hadoop fix_checksumfs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hadoop/pull/290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #290
----
commit b31cd6882ca89b18bb229ef108022026d284c70a
Author: Mathieu Chataigner <m....@criteo.com>
Date: 2017-11-09T18:23:48Z
HADOOP-14128. fix renameInternal in ChecksumFs
AbstractFs.rename(source, destination, options) calls
renameInternal(source, destination, overwrite)
This patch adds this method to ChecksumFs to rename the crc file in
addition to the file itself to avoid crc missmatch when use for example
in LocalFs.
----
> ChecksumFs should override rename with overwrite flag
> -----------------------------------------------------
>
> Key: HADOOP-14128
> URL: https://issues.apache.org/jira/browse/HADOOP-14128
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, fs
> Reporter: Mathieu Chataigner
> Attachments: HADOOP-14128.001.patch
>
>
> When I call FileContext.rename(src, dst, Options.Rename.OVERWRITE) on a LocalFs (which extends ChecksumFs), it does not update crc files.
> Every subsequent read on moved files will result in failures due to crc missmatch.
> One solution is to override rename(src, dst, overwrite) the same way it's done with rename(src, dst) and moving crc files accordingly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org