You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/12/15 13:05:48 UTC

Review Request 29049: Minor UI changes for enabling AMS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29049/
-----------------------------------------------------------

Review request for Ambari and Alexandr Antonenko.


Bugs: ambari-8708
    https://issues.apache.org/jira/browse/ambari-8708


Repository: ambari


Description
-------

*Key changes*:
- Install wizard displays warning message if AMS is selected (but Ganglia is not selected - Ganglia will be removed from stack definition at some point in 2.0 dev cycle, but we need to remove this check now):
{code}
You did not select Ganglia. If Ganglia is not selected, monitoring and alerts will not function properly. Is this OK?
{code}
- AMS Configuration page
-- ams-site should be displayed as "Metric Collector" category
-- Add a General section with the following properties:
--- timeline.metrics.service.operation.mode - default "embedded"
-- Move the following from ams-site (i.e., Metric Collector) to "Advanced ams-site" category
--- timeline.metrics.hbase.compression.scheme
--- timeline.metrics.hbase.data.block.encoding
--- All *.ttl properties (E.g.: timeline.metrics.host.aggregator.minute.ttl)


Diffs
-----

  ambari-web/app/controllers/wizard/step4_controller.js 3a72854 
  ambari-web/app/data/HDP2/site_properties.js 835d1c0 
  ambari-web/app/models/stack_service.js 3b2b42e 
  ambari-web/test/controllers/wizard/step4_test.js a8ec9b9 

Diff: https://reviews.apache.org/r/29049/diff/


Testing
-------

5146 tests complete (8 seconds)
  64 tests pending


Thanks,

Oleg Nechiporenko


Re: Review Request 29049: Minor UI changes for enabling AMS

Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29049/#review65081
-----------------------------------------------------------

Ship it!


Ship It!

- Alexandr Antonenko


On Dec. 15, 2014, 12:05 p.m., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29049/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2014, 12:05 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: ambari-8708
>     https://issues.apache.org/jira/browse/ambari-8708
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> *Key changes*:
> - Install wizard displays warning message if AMS is selected (but Ganglia is not selected - Ganglia will be removed from stack definition at some point in 2.0 dev cycle, but we need to remove this check now):
> {code}
> You did not select Ganglia. If Ganglia is not selected, monitoring and alerts will not function properly. Is this OK?
> {code}
> - AMS Configuration page
> -- ams-site should be displayed as "Metric Collector" category
> -- Add a General section with the following properties:
> --- timeline.metrics.service.operation.mode - default "embedded"
> -- Move the following from ams-site (i.e., Metric Collector) to "Advanced ams-site" category
> --- timeline.metrics.hbase.compression.scheme
> --- timeline.metrics.hbase.data.block.encoding
> --- All *.ttl properties (E.g.: timeline.metrics.host.aggregator.minute.ttl)
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step4_controller.js 3a72854 
>   ambari-web/app/data/HDP2/site_properties.js 835d1c0 
>   ambari-web/app/models/stack_service.js 3b2b42e 
>   ambari-web/test/controllers/wizard/step4_test.js a8ec9b9 
> 
> Diff: https://reviews.apache.org/r/29049/diff/
> 
> 
> Testing
> -------
> 
> 5146 tests complete (8 seconds)
>   64 tests pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>