You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/12/09 01:00:12 UTC
[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter
sonatype-lift[bot] commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1043963255
##########
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##########
@@ -0,0 +1,62 @@
+package org.apache.solr.opentelemetry;
+
+import io.opentelemetry.opentracingshim.OpenTracingShim;
+import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
+import io.opentracing.Tracer;
+import java.lang.invoke.MethodHandles;
+import java.util.Locale;
+import java.util.Objects;
+import org.apache.solr.core.TracerConfigurator;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class OtelTracerConfigurator extends TracerConfigurator {
+ private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ @Override
+ public Tracer getTracer() {
+ log.info("Configuring tracer {}...", getClass().getName());
+
+ setDefaultIfNotConfigured("OTEL_SERVICE_NAME", "solr");
+ setDefaultIfNotConfigured("OTEL_TRACES_EXPORTER", "otlp");
+ setDefaultIfNotConfigured("OTEL_EXPORTER_OTLP_PROTOCOL", "grpc");
+ setDefaultIfNotConfigured("OTEL_TRACES_SAMPLER", "parentbased_always_on");
+
+ System.getenv().entrySet().stream()
+ .filter(e -> e.getKey().startsWith("OTEL_"))
+ .forEach(entry -> log.info("Environment {}={}", entry.getKey(), entry.getValue()));
+
+ // Need to disable the exporters for metrics and logs
+ String metricsExporter = getEnvOrSysprop("OTEL_METRICS_EXPORTER");
+ String logsExporter = getEnvOrSysprop("OTEL_LOGS_EXPORTER");
+ if (metricsExporter != null && !Objects.equals(metricsExporter, "none")
Review Comment:
*[OperatorPrecedence](https://errorprone.info/bugpattern/OperatorPrecedence):* Use grouping parenthesis to make the operator precedence explicit
---
```suggestion
if ((metricsExporter != null && !Objects.equals(metricsExporter, "none"))
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=359492009&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=359492009&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=359492009&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=359492009&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=359492009&lift_comment_rating=5) ]
##########
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##########
@@ -0,0 +1,62 @@
+package org.apache.solr.opentelemetry;
+
+import io.opentelemetry.opentracingshim.OpenTracingShim;
+import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
+import io.opentracing.Tracer;
+import java.lang.invoke.MethodHandles;
+import java.util.Locale;
+import java.util.Objects;
+import org.apache.solr.core.TracerConfigurator;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class OtelTracerConfigurator extends TracerConfigurator {
+ private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ @Override
+ public Tracer getTracer() {
+ log.info("Configuring tracer {}...", getClass().getName());
+
+ setDefaultIfNotConfigured("OTEL_SERVICE_NAME", "solr");
+ setDefaultIfNotConfigured("OTEL_TRACES_EXPORTER", "otlp");
+ setDefaultIfNotConfigured("OTEL_EXPORTER_OTLP_PROTOCOL", "grpc");
+ setDefaultIfNotConfigured("OTEL_TRACES_SAMPLER", "parentbased_always_on");
+
+ System.getenv().entrySet().stream()
+ .filter(e -> e.getKey().startsWith("OTEL_"))
+ .forEach(entry -> log.info("Environment {}={}", entry.getKey(), entry.getValue()));
+
+ // Need to disable the exporters for metrics and logs
+ String metricsExporter = getEnvOrSysprop("OTEL_METRICS_EXPORTER");
+ String logsExporter = getEnvOrSysprop("OTEL_LOGS_EXPORTER");
+ if (metricsExporter != null && !Objects.equals(metricsExporter, "none")
+ || logsExporter != null && !Objects.equals(logsExporter, "none")) {
Review Comment:
*[OperatorPrecedence](https://errorprone.info/bugpattern/OperatorPrecedence):* Use grouping parenthesis to make the operator precedence explicit
---
```suggestion
|| (logsExporter != null && !Objects.equals(logsExporter, "none"))) {
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=359492041&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=359492041&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=359492041&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=359492041&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=359492041&lift_comment_rating=5) ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org