You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Usiel (via GitHub)" <gi...@apache.org> on 2023/09/06 14:24:45 UTC
[GitHub] [airflow] Usiel opened a new pull request, #34136: Ensure details panel is shown when any tab is selected
Usiel opened a new pull request, #34136:
URL: https://github.com/apache/airflow/pull/34136
closes https://github.com/apache/airflow/issues/34132
When creating the feature request I was only thinking of the Graph tab. However, while playing with this I realized that whenever `tab` is set, the user will expect to see the details panel and the requested tab.
There are 2 main scenarios where a user would navigate to a link with the `tab` query param set:
1. User clicks on one of the pills on the DAG view (Graph, Gantt, Code). Imo, the user will expect to see the relevant tab in the details panel, even if they have hid it previously.
2. User clicks on a link (e.g. from DAG runs, or someone sharing a link). Less clear cut than scenario 1, but still I think the most user friendly result is to show the requested tab (in the details panel).
The behavior is so that we do not change the user's setting, if they go back to the grid view the details panel will be hidden if that was their original setting.
I think there is still room for improvement, the UI feels slightly inconsistent due to the different methods of achieving the same state. This PR is just a tiny change to (hopefully) make this a bit less confusing to the user.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #34136: Ensure details panel is shown when any tab is selected
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #34136:
URL: https://github.com/apache/airflow/pull/34136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Usiel commented on pull request #34136: Ensure details panel is shown when any tab is selected
Posted by "Usiel (via GitHub)" <gi...@apache.org>.
Usiel commented on PR #34136:
URL: https://github.com/apache/airflow/pull/34136#issuecomment-1708672714
> Good idea. I wonder if we want to get rid of the localStorage part of this then.
Hmm I was wondering if this was a remnant of a full page reload or similar, but after looking at https://github.com/apache/airflow/pull/22123 I don't think that's the case. I think it would be fine to remove the `localStorage` usage and also not to remember this at all (-> revert back to showing the panel on a reload), but then again I never hid the panel on purpose, so maybe I'm not the target audience 😄
> Also, mind to double check lint and type checks?
I reran the "Static checks" step (`breeze static-checks --all-files --show-diff-on-failure --color always --initialize-environment`) locally, all green here.
(The GitHub actions run failed due to timeout: "The job running on runner GitHub Actions 69 has exceeded the maximum execution time of 30 minutes.")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #34136: Ensure details panel is shown when any tab is selected
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #34136:
URL: https://github.com/apache/airflow/pull/34136#issuecomment-1708575131
Good idea. I wonder if we want to get rid of the localStorage part of this then.
Also, mind to double check lint and type checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org