You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2021/01/26 19:56:15 UTC
[GitHub] [mesos] cf-natali opened a new pull request #379: Fix flaky MasterTest.NonCheckpointingFrameworkAgentDisconnectionExecutorOnly.
cf-natali opened a new pull request #379:
URL: https://github.com/apache/mesos/pull/379
After stopping the driver, we need to wait for the events to reach the
master before checking that the framework has been removed.
It could be reproduced with the following:
```
$ ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=MasterTest.NonCheckpointingFrameworkAgentDisconnectionExecutorOnly
[...]
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from MasterTest
[ RUN ] MasterTest.NonCheckpointingFrameworkAgentDisconnectionExecutorOnly
../../src/tests/master_tests.cpp:7797: Failure
Expected: 0
To be equal to: response->get_frameworks().frameworks_size()
Which is: 1
*** Aborted at 1611689737 (unix time) try "date -d @1611689737" if you are using GNU date ***
PC: @ 0x555e47d02d6d testing::UnitTest::AddTestPartResult()
*** SIGSEGV (@0x0) received by PID 12751 (TID 0x7fbac1607b00) from PID 0; stack trace: ***
@ 0x7fbac2d91730 (unknown)
@ 0x555e47d02d6d testing::UnitTest::AddTestPartResult()
@ 0x555e47cf5b7f testing::internal::AssertHelper::operator=()
@ 0x555e46bf3cdb mesos::internal::tests::MasterTest_NonCheckpointingFrameworkAgentDisconnectionExecutorOnly_Test::TestBody()
@ 0x555e47d225f0 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x555e47d1cdb0 testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x555e47cfc896 testing::Test::Run()
@ 0x555e47cfd104 testing::TestInfo::Run()
@ 0x555e47cfd74d testing::TestCase::Run()
@ 0x555e47d04299 testing::internal::UnitTestImpl::RunAllTests()
@ 0x555e47d233c6 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x555e47d1d8e6 testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x555e47d02f90 testing::UnitTest::Run()
@ 0x555e468d509b RUN_ALL_TESTS()
@ 0x555e468d4b15 main
@ 0x7fbac2be209b __libc_start_main
@ 0x555e45a374ca _start
Segmentation fault
```
@bmahler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] bmahler closed pull request #379: Fix flaky MasterTest.NonCheckpointingFrameworkAgentDisconnectionExecutorOnly.
Posted by GitBox <gi...@apache.org>.
bmahler closed pull request #379:
URL: https://github.com/apache/mesos/pull/379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] bmahler commented on pull request #379: Fix flaky MasterTest.NonCheckpointingFrameworkAgentDisconnectionExecutorOnly.
Posted by GitBox <gi...@apache.org>.
bmahler commented on pull request #379:
URL: https://github.com/apache/mesos/pull/379#issuecomment-769397228
Merged, thanks for the fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org