You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by amberarrow <gi...@git.apache.org> on 2016/04/06 18:21:16 UTC

[GitHub] incubator-apex-core pull request: Add doc section on running unit ...

GitHub user amberarrow opened a pull request:

    https://github.com/apache/incubator-apex-core/pull/297

    Add doc section on running unit tests

    Added section on running unit tests and installing winutils.exe on Windows.
    @tweise Please review and merge


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amberarrow/incubator-apex-core doc-unittesting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-core/pull/297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #297
    
----
commit 2c061f8246377b424ee3e1018b62682cb671006d
Author: Munagala V. Ramanath <ra...@datatorrent.com>
Date:   2016-04-06T16:18:37Z

    Add doc section on running unit tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Add doc section on running unit ...

Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/297#discussion_r58736703
  
    --- Diff: docs/apex_development_setup.md ---
    @@ -94,6 +94,38 @@ When the run completes successfully, you should see a new directory named `myape
     
     The build should create the application package file `myapexapp/target/myapexapp-1.0-SNAPSHOT.apa`. This application package can then be used to launch example application via **dtCli**, or other visual management tools.  When running, this application will generate a stream of random numbers and print them out, each prefixed by the string `hello world:`.
     
    +Running Unit Tests
    +----
    +To run unit tests on Linux or OSX, simply run the usual maven command, for example: `mvn test`.
    +
    +On Windows, an additional file, `winutils.exe`, is required; download it from
    +<https://github.com/srccodes/hadoop-common-2.2.0-bin/archive/master.zip>
    +and unpack the archive to, say, `C:\hadoop`; this file should be present under
    +`hadoop-common-2.2.0-bin-master\bin` within it.
    +
    +You can now run unit tests from the command line by specifying the maven
    +property `hadoop.home.dir`, for example:
    +
    +    mvn -Dhadoop.home.dir=c:\hadoop\Software\hadoop-common-2.2.0-bin-master test
    +
    +or set the environment variable separately:
    +
    +    set HADOOP_HOME=c:\hadoop\Software\hadoop-common-2.2.0-bin-master
    +    mvn test
    +
    +To run unit tests from within your IDE, set the `HADOOP_HOME` environment
    --- End diff --
    
    Can also be set system wide and then no IDE tweaks are needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Add doc section on running unit ...

Posted by amberarrow <gi...@git.apache.org>.
Github user amberarrow commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/297#discussion_r58738987
  
    --- Diff: docs/apex_development_setup.md ---
    @@ -94,6 +94,38 @@ When the run completes successfully, you should see a new directory named `myape
     
     The build should create the application package file `myapexapp/target/myapexapp-1.0-SNAPSHOT.apa`. This application package can then be used to launch example application via **dtCli**, or other visual management tools.  When running, this application will generate a stream of random numbers and print them out, each prefixed by the string `hello world:`.
     
    +Running Unit Tests
    +----
    +To run unit tests on Linux or OSX, simply run the usual maven command, for example: `mvn test`.
    +
    +On Windows, an additional file, `winutils.exe`, is required; download it from
    +<https://github.com/srccodes/hadoop-common-2.2.0-bin/archive/master.zip>
    +and unpack the archive to, say, `C:\hadoop`; this file should be present under
    +`hadoop-common-2.2.0-bin-master\bin` within it.
    +
    +You can now run unit tests from the command line by specifying the maven
    +property `hadoop.home.dir`, for example:
    +
    +    mvn -Dhadoop.home.dir=c:\hadoop\Software\hadoop-common-2.2.0-bin-master test
    +
    +or set the environment variable separately:
    +
    +    set HADOOP_HOME=c:\hadoop\Software\hadoop-common-2.2.0-bin-master
    +    mvn test
    +
    +To run unit tests from within your IDE, set the `HADOOP_HOME` environment
    --- End diff --
    
    Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Add doc section on running unit ...

Posted by sandeshh <gi...@git.apache.org>.
Github user sandeshh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/297#discussion_r58764149
  
    --- Diff: docs/apex_development_setup.md ---
    @@ -94,6 +94,42 @@ When the run completes successfully, you should see a new directory named `myape
     
     The build should create the application package file `myapexapp/target/myapexapp-1.0-SNAPSHOT.apa`. This application package can then be used to launch example application via **dtCli**, or other visual management tools.  When running, this application will generate a stream of random numbers and print them out, each prefixed by the string `hello world:`.
     
    +Running Unit Tests
    +----
    +To run unit tests on Linux or OSX, simply run the usual maven command, for example: `mvn test`.
    +
    +On Windows, an additional file, `winutils.exe`, is required; download it from
    +<https://github.com/srccodes/hadoop-common-2.2.0-bin/archive/master.zip>
    +and unpack the archive to, say, `C:\hadoop`; this file should be present under
    +`hadoop-common-2.2.0-bin-master\bin` within it.
    +
    --- End diff --
    
    Have we tried this ? In the users mailing list, it was mentioned that 2.6 worked. That doc you referenced is from Windows XP page, which is not supported anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Add doc section on running unit ...

Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/297#discussion_r58737026
  
    --- Diff: docs/apex_development_setup.md ---
    @@ -94,6 +94,38 @@ When the run completes successfully, you should see a new directory named `myape
     
     The build should create the application package file `myapexapp/target/myapexapp-1.0-SNAPSHOT.apa`. This application package can then be used to launch example application via **dtCli**, or other visual management tools.  When running, this application will generate a stream of random numbers and print them out, each prefixed by the string `hello world:`.
     
    +Running Unit Tests
    +----
    +To run unit tests on Linux or OSX, simply run the usual maven command, for example: `mvn test`.
    +
    +On Windows, an additional file, `winutils.exe`, is required; download it from
    +<https://github.com/srccodes/hadoop-common-2.2.0-bin/archive/master.zip>
    +and unpack the archive to, say, `C:\hadoop`; this file should be present under
    +`hadoop-common-2.2.0-bin-master\bin` within it.
    +
    +You can now run unit tests from the command line by specifying the maven
    +property `hadoop.home.dir`, for example:
    +
    +    mvn -Dhadoop.home.dir=c:\hadoop\Software\hadoop-common-2.2.0-bin-master test
    +
    +or set the environment variable separately:
    +
    +    set HADOOP_HOME=c:\hadoop\Software\hadoop-common-2.2.0-bin-master
    +    mvn test
    +
    +To run unit tests from within your IDE, set the `HADOOP_HOME` environment
    --- End diff --
    
    Should mention that first as it covers command line as well. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Add doc section on running unit ...

Posted by amberarrow <gi...@git.apache.org>.
Github user amberarrow commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/297#discussion_r58765782
  
    --- Diff: docs/apex_development_setup.md ---
    @@ -94,6 +94,42 @@ When the run completes successfully, you should see a new directory named `myape
     
     The build should create the application package file `myapexapp/target/myapexapp-1.0-SNAPSHOT.apa`. This application package can then be used to launch example application via **dtCli**, or other visual management tools.  When running, this application will generate a stream of random numbers and print them out, each prefixed by the string `hello world:`.
     
    +Running Unit Tests
    +----
    +To run unit tests on Linux or OSX, simply run the usual maven command, for example: `mvn test`.
    +
    +On Windows, an additional file, `winutils.exe`, is required; download it from
    +<https://github.com/srccodes/hadoop-common-2.2.0-bin/archive/master.zip>
    +and unpack the archive to, say, `C:\hadoop`; this file should be present under
    +`hadoop-common-2.2.0-bin-master\bin` within it.
    +
    --- End diff --
    
    Yes, I tried downloading master.zip, unpacking and setting the environment variable locally within the IDE as well as on the console on Windows 10.
    
    Describing how to set the environment variable globally is different in different versions of Windows and covering all variants would introduce too much verbiage into the document. There are tons of web pages that show how to do it, I just picked one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Add doc section on running unit ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-apex-core/pull/297


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---