[jira] [Commented] (NIFI-4504) SimpleMapCache/PersistentMapCache: Add removeAndGet and removeByPatternAndGet

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304045#comment-16304045 ] 

ASF GitHub Bot commented on NIFI-4504:
--------------------------------------

Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/2284
  
    @mosermw can you rebase and force push so we can get travis to do its thing.
    
    We need someone to review.  It *might* be best to make it smaller by leaving these new methods unsupported/unused in the existing processors if I'm understanding that right.


> SimpleMapCache/PersistentMapCache: Add removeAndGet and removeByPatternAndGet
> -----------------------------------------------------------------------------
>
>                 Key: NIFI-4504
>                 URL: https://issues.apache.org/jira/browse/NIFI-4504
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Jon Kessler
>            Assignee: Michael Moser
>            Priority: Minor
>
> Typical map implementations return the value that was removed when performing a remove. Because you couldn't update the existing remove methods without it being a breaking change I suggest adding new versions of the remove and removeByPattern methods that return the removed value(s).
> These changes should also be applied up the chain to any class that makes use of these classes such as the MapCacheServer and AtomicDistributedMapCacheClient.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)