[GitHub] [spark] zhengruifeng commented on a diff in pull request #40603: [MINOR][CONNECT] Adding Proto Debug String to Job Description.

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #40603:
URL: https://github.com/apache/spark/pull/40603#discussion_r1159479080


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala:
##########
@@ -49,6 +50,16 @@ class SparkConnectStreamHandler(responseObserver: StreamObserver[ExecutePlanResp
         .getOrCreateIsolatedSession(v.getUserContext.getUserId, v.getSessionId)
         .session
     session.withActive {
+
+      // Add debug information to the query execution so that the jobs are traceable.
+      val debugString = v.toString

Review Comment:
   `v.toString` is problematic in some cases, see https://github.com/apache/spark/pull/40607/files#r1159434752
   
   I think we have to manually implement it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org