You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2023/01/18 16:46:51 UTC
[GitHub] [apisix-ingress-controller] AlinsRan opened a new pull request, #1605: doc: add svc-namespace description to the annotations
AlinsRan opened a new pull request, #1605:
URL: https://github.com/apache/apisix-ingress-controller/pull/1605
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] navendu-pottekkat commented on a diff in pull request #1605: doc: add svc-namespace description to the annotations
Posted by "navendu-pottekkat (via GitHub)" <gi...@apache.org>.
navendu-pottekkat commented on code in PR #1605:
URL: https://github.com/apache/apisix-ingress-controller/pull/1605#discussion_r1089938717
##########
docs/en/latest/concepts/annotations.md:
##########
@@ -360,3 +360,32 @@ spec:
port:
number: 50053
```
+
+## Cross namespace reference service
Review Comment:
Then that could be mentioned in the description? "cross-namespace reference service" does not convey the meaning that it is cross-namespace reference for services. Hence I suggested just cross-namespace reference. When a user then reads the description it will be clear that this annotation is used to reference services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1605: doc: add svc-namespace description to the annotations
Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan commented on code in PR #1605:
URL: https://github.com/apache/apisix-ingress-controller/pull/1605#discussion_r1089848134
##########
docs/en/latest/concepts/annotations.md:
##########
@@ -360,3 +360,32 @@ spec:
port:
number: 50053
```
+
+## Cross namespace reference service
Review Comment:
The "cross-namespace references" include objects such as secret. In fact, only service is supported here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] navendu-pottekkat commented on a diff in pull request #1605: doc: add svc-namespace description to the annotations
Posted by "navendu-pottekkat (via GitHub)" <gi...@apache.org>.
navendu-pottekkat commented on code in PR #1605:
URL: https://github.com/apache/apisix-ingress-controller/pull/1605#discussion_r1083391377
##########
docs/en/latest/concepts/annotations.md:
##########
@@ -360,3 +360,32 @@ spec:
port:
number: 50053
```
+
+## Cross namespace reference service
Review Comment:
Maybe it can just be "Cross-namespace reference"?
##########
docs/en/latest/concepts/annotations.md:
##########
@@ -360,3 +360,32 @@ spec:
port:
number: 50053
```
+
+## Cross namespace reference service
+
+The value of the annotation should be the namespace of the service.
Review Comment:
"This annotation can be used to route to services in a different namespace."
Or something that explains what this annotation does.
##########
docs/en/latest/concepts/annotations.md:
##########
@@ -360,3 +360,32 @@ spec:
port:
number: 50053
```
+
+## Cross namespace reference service
+
+The value of the annotation should be the namespace of the service.
+
+In the example configuration below, the Ingress resource in the default namespace references the httpbin service from the test namespace:
Review Comment:
```suggestion
In the example configuration below, the Ingress resource in the `default` namespace references the httpbin service in the `test` namespace:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] navendu-pottekkat merged pull request #1605: doc: add svc-namespace description to the annotations
Posted by "navendu-pottekkat (via GitHub)" <gi...@apache.org>.
navendu-pottekkat merged PR #1605:
URL: https://github.com/apache/apisix-ingress-controller/pull/1605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1605: doc: add svc-namespace description to the annotations
Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan commented on code in PR #1605:
URL: https://github.com/apache/apisix-ingress-controller/pull/1605#discussion_r1090152840
##########
docs/en/latest/concepts/annotations.md:
##########
@@ -360,3 +360,32 @@ spec:
port:
number: 50053
```
+
+## Cross namespace reference service
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org