[PR] improve rolling update code [pekko-management]

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning opened a new pull request, #913:
URL: https://github.com/apache/pekko-management/pull/913

   L8 — Double toStrict: Removed the redundant responseEntity.toStrict(settings.bodyReadTimeout) call in getReplicaSet's error path (line 392). The entity was already made strict at line 382.
   
   L9 — Connection leak on timeout: Replaced Future.firstCompletedOf in makeRequest with a Promise-based approach (same pattern as the lease fix). When timeout fires, response.foreach(_.discardEntityBytes()) ensures the response entity is consumed if one arrives later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] rolling update code - fix Double toStrict [pekko-management]

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning merged PR #913:
URL: https://github.com/apache/pekko-management/pull/913


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org