You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Rohini Palaniswamy (JIRA)" <ji...@apache.org> on 2019/02/15 19:42:00 UTC
[jira] [Commented] (PIG-5377) Move
supportsParallelWriteToStoreLocation from StoreFunc to StoreFuncInterfce
[ https://issues.apache.org/jira/browse/PIG-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769645#comment-16769645 ]
Rohini Palaniswamy commented on PIG-5377:
-----------------------------------------
Just couple of minor comments.
1) Can you rename testUnionUnSupportedStore -> testUnionIncludeExcludeStoreFunc and move the test code with TEZC-Union-1-DummyStore3.gld from testUnionStore after TEZC-Union-1-DummyStore2.gld.
2) TestDummyStoreFuncOptimizationEnabled -> TestDummyStoreFuncParallelWriteEnabled
TestDummyStoreFuncOptimizationDisabled -> TestDummyStoreFuncParallelWriteDisabled
3) Can you add the LOG.warn(name + " does not support union optimization. Disabling it. There will be some performance degradation."); msg to unsupportedStoreFuncs != null && unsupportedStoreFuncs.contains(name) block as well?
> Move supportsParallelWriteToStoreLocation from StoreFunc to StoreFuncInterfce
> -----------------------------------------------------------------------------
>
> Key: PIG-5377
> URL: https://issues.apache.org/jira/browse/PIG-5377
> Project: Pig
> Issue Type: Improvement
> Components: internal-udfs, piggybank
> Reporter: Kevin J. Price
> Assignee: Kevin J. Price
> Priority: Minor
> Attachments: PIG-5377.patch
>
>
> Now that we're running on JDK8 and can have default implementations in interfaces, we can move supportsParallelWriteToStoreLocation() to the StoreFuncInterface class and properly set it on the supported built-in functions rather than having a static list.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)