You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/04 02:40:49 UTC

[GitHub] [incubator-superset] maxamante opened a new pull request #12239: fix(ChartTable): replace root React.Fragment with ErrorBoundary

maxamante opened a new pull request #12239:
URL: https://github.com/apache/incubator-superset/pull/12239


   ### SUMMARY
   Hello, I am interested in contributing to Superset. Found issue #12149 and thought it would be a good way to learn the system.  If you would like me to create a separate issue for this, I can do that.
   
   #12149 wants to add an ErrorBoundary to specific components. I picked the ChartTable on the Welcome component, which I believe is the same as the **2nd item** under the **5. Home Page** mentioned in the issue. I replaced the root React.Fragment with an ErrorBoundary. I found the router logic and some other components using the ErrorBoundary this way.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A
   
   ### TEST PLAN
   I wasn't sure how to proceed with testing. I didn't find any tests that tested the ErrorBoundary or any components that import the ErrorBoundary. The superset-ui repo has [some test examples](https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-core/test/chart/components/SuperChart.test.tsx#L49) I can take cues from. Advice would be great!
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Progresses #12149 Fixes 5.2. Charts
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org