You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2013/08/02 15:15:30 UTC

Review Request 13240: dealt with some warnings in NetworkServiceImpl

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13240/
-----------------------------------------------------------

Review request for cloudstack.


Repository: cloudstack-git


Description
-------

dealt with some warnings in NetworkServiceImpl


Diffs
-----

  server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 

Diff: https://reviews.apache.org/r/13240/diff/


Testing
-------


Thanks,

daan Hoogland

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13240/#review24576
-----------------------------------------------------------



server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/13240/#comment48591>

    Don't remove it... It's a bug here.
    
    It should be 
    if ((networkId == null && vpcId == null) || (networkId != null && vpcId != null)) {
    
    || rather than &&


- Sheng Yang


On Aug. 2, 2013, 1:15 p.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13240/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 1:15 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> dealt with some warnings in NetworkServiceImpl
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 
> 
> Diff: https://reviews.apache.org/r/13240/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13240/#review24529
-----------------------------------------------------------


Review 13240 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #109 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/109/

- Jenkins Cloudstack.org


On Aug. 2, 2013, 1:15 p.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13240/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 1:15 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> dealt with some warnings in NetworkServiceImpl
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 
> 
> Diff: https://reviews.apache.org/r/13240/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

Posted by Sheng Yang <sh...@yasker.org>.

> On Aug. 5, 2013, 6:19 p.m., Sheng Yang wrote:
> > Ship It!

Pushed to 4.2 and MASTER.


- Sheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13240/#review24654
-----------------------------------------------------------


On Aug. 5, 2013, 9:59 a.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13240/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 9:59 a.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> dealt with some warnings in NetworkServiceImpl
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 
> 
> Diff: https://reviews.apache.org/r/13240/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13240/#review24654
-----------------------------------------------------------

Ship it!


Ship It!

- Sheng Yang


On Aug. 5, 2013, 9:59 a.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13240/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 9:59 a.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> dealt with some warnings in NetworkServiceImpl
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 
> 
> Diff: https://reviews.apache.org/r/13240/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13240/
-----------------------------------------------------------

(Updated Aug. 5, 2013, 9:59 a.m.)


Review request for cloudstack, Chiradeep Vittal and Sheng Yang.


Changes
-------

added chiradeep


Repository: cloudstack-git


Description
-------

dealt with some warnings in NetworkServiceImpl


Diffs
-----

  server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 

Diff: https://reviews.apache.org/r/13240/diff/


Testing
-------


Thanks,

daan Hoogland

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13240/
-----------------------------------------------------------

(Updated Aug. 5, 2013, 9:36 a.m.)


Review request for cloudstack and Sheng Yang.


Changes
-------

adding Sheng


Repository: cloudstack-git


Description
-------

dealt with some warnings in NetworkServiceImpl


Diffs
-----

  server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 

Diff: https://reviews.apache.org/r/13240/diff/


Testing
-------


Thanks,

daan Hoogland

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13240/
-----------------------------------------------------------

(Updated Aug. 3, 2013, 9:54 a.m.)


Review request for cloudstack.


Changes
-------

fixed a expresion that resulted in false to a real test according to advice by Sheng


Repository: cloudstack-git


Description
-------

dealt with some warnings in NetworkServiceImpl


Diffs (updated)
-----

  server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 

Diff: https://reviews.apache.org/r/13240/diff/


Testing
-------


Thanks,

daan Hoogland