You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/20 15:34:17 UTC

[GitHub] jiangxb1987 commented on a change in pull request #23844: [SPARK-26939][CORE][DOC] Fix some outdated comments about task schedulers

jiangxb1987 commented on a change in pull request #23844: [SPARK-26939][CORE][DOC] Fix some outdated comments about task schedulers
URL: https://github.com/apache/spark/pull/23844#discussion_r258537741
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/TaskScheduler.scala
 ##########
 @@ -23,8 +23,7 @@ import org.apache.spark.storage.BlockManagerId
 import org.apache.spark.util.AccumulatorV2
 
 /**
- * Low-level task scheduler interface, currently implemented exclusively by
- * [[org.apache.spark.scheduler.TaskSchedulerImpl]].
 
 Review comment:
   I would prefer keep this line, since we still have this assumption across Spark internal, and YARN scheduler is still a `TaskSchedulerImpl`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org