You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "soreana (via GitHub)" <gi...@apache.org> on 2023/06/08 10:50:28 UTC
[GitHub] [cloudstack] soreana opened a new issue, #7608: use.system.public.ips does nothing when domain doesn't have a range
soreana opened a new issue, #7608:
URL: https://github.com/apache/cloudstack/issues/7608
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
IP assignment
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
4.17,
4.18,
main (*)
~~~
(*): Although I didn't test that on main branch, the code pard didn't change so it should be there as well.
##### SUMMARY
<!-- Explain the problem/feature briefly -->
By default when user use all of their assigned public IPs, they can use system public IPs. Although by using the `use.system.public.ips` setting admins can prevent that action, the setting doesn't have any affect when user doesn't have any reserved range.
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
1. Login as a `root admin`
2. Create a domain and a domain admin account for the domain.
3. Set `use.system.public.ips` to `false` in the account, the domain or globally.
4. Assign an IP range to the domain or the account. `[Range 1]`
5. Login as a `domain admin` and create an isolated network in domain.
6. Go to the isolated network page and click on the `Public IP addresses` then click on `Acquire new IP`.
7. The list shows only the IPs in the assinged IP range `[Range 1]`
8. Logout and login as a `root admin` again
9. Remove the `[Range1]` IP range assignment.
10. Repeat step `5`, `6`, and `7`. The output list now includes the system IPs.
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
User can NOT see the system's public IP addresses.
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
User can see the system's public IP addresses.
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kiranchavala commented on issue #7608: use.system.public.ips does nothing when domain doesn't have a range
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on issue #7608:
URL: https://github.com/apache/cloudstack/issues/7608#issuecomment-1584440588
@DaanHoogland able to reproduce the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7608: use.system.public.ips does nothing when domain doesn't have a range
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7608:
URL: https://github.com/apache/cloudstack/issues/7608#issuecomment-1587027749
this seems to be expected behaviour.
(at least it behaves like it from many years ago)
I suggest not to change it, otherwise it will cause backwards compatilbility, and impact some existing environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on issue #7608: use.system.public.ips does nothing when domain doesn't have a range
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on issue #7608:
URL: https://github.com/apache/cloudstack/issues/7608#issuecomment-1598401162
> > @weizhouapache Honestly, Before double checking the global setting definition I wasn't agree with you. But now it makes sense not to touch the global settings behaviour.
> > Shall I add a new setting called `restric.system.public.ips.access` which restricts public IP access even if user doesn't have the dedicated range?
> > ```
> > Definition of "use.system.public.ips"
> > If true, when account has dedicated public ip range(s), once the ips dedicated to the account have been consumed ips will be acquired from the system pool
> > ```
>
> @soreana good idea. go for it.
>
> can we close this ticket as it is not a real issue ?
I would create a PR for that.
Btw, I think it is better to keep it open. I would change it in a way that it reflects our discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7608: use.system.public.ips does nothing when domain doesn't have a range
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #7608:
URL: https://github.com/apache/cloudstack/issues/7608#issuecomment-1584500568
@soreana are you creating a PR for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on issue #7608: use.system.public.ips does nothing when domain doesn't have a range
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on issue #7608:
URL: https://github.com/apache/cloudstack/issues/7608#issuecomment-1586991837
Hey @DaanHoogland Yes, I'm going to create a PR for this issue. Any suggestion appreciated :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on issue #7608: use.system.public.ips does nothing when domain doesn't have a range
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on issue #7608:
URL: https://github.com/apache/cloudstack/issues/7608#issuecomment-1587180618
@weizhouapache Honestly, Before double checking the global setting definition I wasn't agree with you. But now it makes sense not to touch the global settings behaviour.
Shall I add a new setting called `restric.system.public.ips.access` which restricts public IP access even if user doesn't have the dedicated range?
```
Definition of "use.system.public.ips"
If true, when account has dedicated public ip range(s), once the ips dedicated to the account have been consumed ips will be acquired from the system pool
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7608: use.system.public.ips does nothing when domain doesn't have a range
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7608:
URL: https://github.com/apache/cloudstack/issues/7608#issuecomment-1597084742
> @weizhouapache Honestly, Before double checking the global setting definition I wasn't agree with you. But now it makes sense not to touch the global settings behaviour.
>
> Shall I add a new setting called `restric.system.public.ips.access` which restricts public IP access even if user doesn't have the dedicated range?
>
> ```
> Definition of "use.system.public.ips"
> If true, when account has dedicated public ip range(s), once the ips dedicated to the account have been consumed ips will be acquired from the system pool
> ```
@soreana good idea. go for it.
can we close this ticket as it is not a real issue ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org