You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/01/24 03:29:19 UTC

Re: [PR] [SPARK-43306][PYTHON] Migrate `ValueError` from Spark SQL types into error class [spark]

HyukjinKwon commented on code in PR #40975:
URL: https://github.com/apache/spark/pull/40975#discussion_r1464254305


##########
python/pyspark/sql/types.py:
##########
@@ -1952,7 +1970,10 @@ def verify_nullability(obj: Any) -> bool:
             if nullable:
                 return True
             else:
-                raise ValueError(new_msg("This field is not nullable, but got None"))

Review Comment:
   You can't remove `new_msg` here .. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org