You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2018/04/20 09:52:29 UTC

[GitHub] brooklyn-server pull request #957: SshCommandSensor.testDslWithSshSensor: co...

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/957

    SshCommandSensor.testDslWithSshSensor: convert to non-integration

    See my comments in PR #953 
    
    This now uses the `RecordingSshTool` to execute the ssh command sensor, so the test is quicker. If you run it 100 times, the first time still takes 2 seconds (presumably due to classloading etc), and then it takes about 200ms per test after that.
    
    Also fixes the final assertion, that it is the `newValue` in the sensor.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server pr953-addendum

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #957
    
----
commit 628f383030538d2810802e6df190a9cd898fc473
Author: Aled Sage <al...@...>
Date:   2018-04-20T09:50:22Z

    SshCommandSensor.testDslWithSshSensor: convert to non-integration

----


---

[GitHub] brooklyn-server issue #957: SshCommandSensor.testDslWithSshSensor: convert t...

Posted by nakomis <gi...@git.apache.org>.

Github user nakomis commented on the issue:

    https://github.com/apache/brooklyn-server/pull/957
  
    LGTM


---

[GitHub] brooklyn-server pull request #957: SshCommandSensor.testDslWithSshSensor: co...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/957


---