[jira] [Commented] (MSHADE-306) Log all duplicates, not only classes

["Piotr Zygielo (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHADE-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035972#comment-17035972 ] 

Piotr Zygielo commented on MSHADE-306:
--------------------------------------

On just released 3.2.2 - How can I not have warning for
{code:bash}
[WARNING] [... jars listed..] define 1 overlapping resources: 
[WARNING] - META-INF/MANIFEST.MF
[WARNING] maven-shade-plugin has detected that some class files are
[WARNING] present in two or more JARs. When this happens, only one
[WARNING] single version of the class is copied to the uber jar.
[WARNING] Usually this is not harmful and you can skip these warnings,
[WARNING] otherwise try to manually exclude artifacts based on
[WARNING] mvn dependency:tree -Ddetail=true and the above output.
[WARNING] See [http://maven.apache.org/plugins/maven-shade-plugin/]
{code}
 
 1. I'd expect that MANIFEST.MFs are present in several jars. Does is mean that warning will be issued for almost every case of plugin usage?
 2. I'd like the message to at least include 'or resources' in 'has detected that some class files'.

> Log all duplicates, not only classes
> ------------------------------------
>
>                 Key: MSHADE-306
>                 URL: https://issues.apache.org/jira/browse/MSHADE-306
>             Project: Maven Shade Plugin
>          Issue Type: New Feature
>            Reporter: Romain Manni-Bucau
>            Assignee: Romain Manni-Bucau
>            Priority: Major
>             Fix For: 3.2.2
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Issue to silently swallow duplicated resources is that you don't see, even in debug, that there is a choice done by the plugin. This breaks the final app in a lot of cases (all SPI-like cases, OSGi for the MANIFEST.MF etc...). So let's log it as for classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)