You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2025/05/10 14:48:56 UTC
[PR] [Python] Added the validate support for ReadAllFromBigQuery [beam]
liferoad opened a new pull request, #34910:
URL: https://github.com/apache/beam/pull/34910
Fixes #34792
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Added the validate support for ReadAllFromBigQuery [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #34910:
URL: https://github.com/apache/beam/pull/34910#issuecomment-2869843532
> I want to add that the pr changes the default behavior of the function. Otherwise lgtm.
It actually fixes the bug since ReadAllFromBigQuery already has the flag but never honors it. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Added the validate support for ReadAllFromBigQuery [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #34910:
URL: https://github.com/apache/beam/pull/34910#issuecomment-2868997967
For my education, when validation is present, what happened if some of the files do not exist due to some reasons? Will BigQuey retry those files or simply ignore them?
Also want to make sure that skipping validation will not lead to any data loss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Added the validate support for ReadAllFromBigQuery [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #34910:
URL: https://github.com/apache/beam/pull/34910#issuecomment-2869140361
It is not related to GCS. We reuse the File IO to load the exported files from BQ. It does not consider how GCS works and assuming checking files exist and removing files are cheap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Added the validate support for ReadAllFromBigQuery [beam]
Posted by "ayestoro (via GitHub)" <gi...@apache.org>.
ayestoro commented on PR #34910:
URL: https://github.com/apache/beam/pull/34910#issuecomment-2868942289
Great implementation of this feature. I particularly like the approach to error handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Added the validate support for ReadAllFromBigQuery [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad merged PR #34910:
URL: https://github.com/apache/beam/pull/34910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Added the validate support for ReadAllFromBigQuery [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #34910:
URL: https://github.com/apache/beam/pull/34910#issuecomment-2869040795
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/34910?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `50.00000%` with `1 line` in your changes missing coverage. Please review.
> Project coverage is 56.49%. Comparing base [(`d427d37`)](https://app.codecov.io/gh/apache/beam/commit/d427d3731e4653374310d693c5e13933529ac488?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`cc734ec`)](https://app.codecov.io/gh/apache/beam/commit/cc734ec6e725896b5afdcb3c745fb8d66cbc8d07?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/beam/pull/34910?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ython/apache\_beam/io/gcp/bigquery\_read\_internal.py](https://app.codecov.io/gh/apache/beam/pull/34910?src=pr&el=tree&filepath=sdks%2Fpython%2Fapache_beam%2Fio%2Fgcp%2Fbigquery_read_internal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3JlYWRfaW50ZXJuYWwucHk=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/34910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #34910 +/- ##
============================================
- Coverage 56.49% 56.49% -0.01%
Complexity 3301 3301
============================================
Files 1182 1183 +1
Lines 181610 181624 +14
Branches 3409 3409
============================================
+ Hits 102599 102606 +7
- Misses 75740 75747 +7
Partials 3271 3271
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/34910/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/34910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.12% <50.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/34910?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Added the validate support for ReadAllFromBigQuery [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34910:
URL: https://github.com/apache/beam/pull/34910#issuecomment-2868995064
Assigning reviewers:
R: @damccorm for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Added the validate support for ReadAllFromBigQuery [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #34910:
URL: https://github.com/apache/beam/pull/34910#issuecomment-2869026248
> For my education, when validation is present, what happened if some of the files do not exist due to some reasons? Will BigQuey retry those files or simply ignore them?
>
> Also want to make sure that skipping validation will not lead to any data loss.
It will fail the pipeline eventually. validate=True just does more early checks to fail the jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Added the validate support for ReadAllFromBigQuery [beam]
Posted by "fivemeyestoreserver (via GitHub)" <gi...@apache.org>.
fivemeyestoreserver commented on PR #34910:
URL: https://github.com/apache/beam/pull/34910#issuecomment-2868942862
Great implementation of this feature. I particularly like the approach to error handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Added the validate support for ReadAllFromBigQuery [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #34910:
URL: https://github.com/apache/beam/pull/34910#issuecomment-2869131488
> > For my education, when validation is present, what happened if some of the files do not exist due to some reasons? Will BigQuey retry those files or simply ignore them?
> > Also want to make sure that skipping validation will not lead to any data loss.
>
> It will fail the pipeline eventually. validate=True just does more early checks to fail the jobs.
I see. So GCS complains about we check existence of those files, but it has no problem when BigQuery processing them. That's weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org