[GitHub] [pinot] KKcorps commented on a diff in pull request #9920: Clean up TableDataManagerConfig to be a thin wrapper over instance and table config

[GitBox <gi...@apache.org>]

KKcorps commented on code in PR #9920:
URL: https://github.com/apache/pinot/pull/9920#discussion_r1043015864


##########
pinot-core/src/test/java/org/apache/pinot/queries/ExplainPlanQueriesTest.java:
##########
@@ -284,7 +285,7 @@ public void setUp()
       tableDataManager.addSegment((ImmutableSegment) indexSegment);
     }
     InstanceDataManager instanceDataManager = mock(InstanceDataManager.class);
-    when(instanceDataManager.getTableDataManager(RAW_TABLE_NAME)).thenReturn(tableDataManager);
+    when(instanceDataManager.getTableDataManager(OFFLINE_TABLE_NAME)).thenReturn(tableDataManager);

Review Comment:
   This change is breaking the test. QueryExecutor is getting table name without type as argument and hence gets no tableDataManager



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org